Skip to content

overhaul (style, tests, coverage, etc.)#103

Merged
rvagg merged 5 commits into
masterfrom
rvagg/modernise
Jun 27, 2020
Merged

overhaul (style, tests, coverage, etc.)#103
rvagg merged 5 commits into
masterfrom
rvagg/modernise

Conversation

@rvagg

@rvagg rvagg commented Jun 24, 2020

Copy link
Copy Markdown
Owner
  • modernise style, introduce standard linting
  • increase test coverage and enforce 100%
  • remove destroy() (it's in Writable these days)
  • remove inherits dependency, use a simple custom one with Object.create()
  • switch from Travis to Github Actions (and test against readable-stream@2 and readable-stream@3 explicitly)
  • add browser testing with polendina
  • switch from tape to mocha & chai (it's just easier in the browser because of the outdated stream-browserify getting tied up with readable-stream here)

should cut the bundle size down by a fair bit too

@rvagg rvagg force-pushed the rvagg/modernise branch from f94a1ae to c0bdc22 Compare June 24, 2020 04:36
@rvagg rvagg force-pushed the rvagg/modernise branch from c0bdc22 to 164d3f8 Compare June 24, 2020 04:42
@rvagg

rvagg commented Jun 24, 2020

Copy link
Copy Markdown
Owner Author

Probably worth a semver-major bump to 4.0.0, it'll probably not work in Node 6 (maybe?) if anyone's still relying on that, and the removal of the custom destroy() and replacing it with the Writable#destroy() could have some breaking effects due to the additional complexity of the latter. Mostly it should be a straightforward upgrade for anyone still using through2.

@rvagg rvagg force-pushed the rvagg/modernise branch from 3f91d1f to 9ad222a Compare June 24, 2020 04:55
@rvagg

rvagg commented Jun 25, 2020

Copy link
Copy Markdown
Owner Author

I think I might remove readable-stream@2 option and just make the dependency "3" (it is currently "2 || 3"), it's about time to move on and encourage others to do so. Any objections?

@mafintosh

Copy link
Copy Markdown
Collaborator

@rvagg +1

@martinheidegger

Copy link
Copy Markdown
Contributor

Following your lead 👍

Comment thread test/bench.js Outdated
Comment thread README.md Outdated
@rvagg

rvagg commented Jun 26, 2020

Copy link
Copy Markdown
Owner Author
  • switched the docs to point to readable-stream
  • cleaned up test/bench.js
  • explicitly require Buffer (in prep for the webpack@5 storm)

Comment thread README.md Outdated
Comment thread test/bench.js

@martinheidegger martinheidegger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over it, can't find any detail anymore 😅

@rvagg rvagg force-pushed the rvagg/modernise branch from f65d6fb to ad542a5 Compare June 27, 2020 10:08
@rvagg rvagg merged commit ad542a5 into master Jun 27, 2020
@rvagg rvagg deleted the rvagg/modernise branch June 27, 2020 10:11
@rvagg

rvagg commented Jun 27, 2020

Copy link
Copy Markdown
Owner Author

published as 4.0.0, then realised .npmignore was out of date and there was cruft in the pack so I fixed that up and pushed a 4.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants