Skip to content

Add power support ppc64le and update versions#34

Merged
ralphtheninja merged 1 commit intorvagg:masterfrom
nagesh4193:master
Dec 16, 2020
Merged

Add power support ppc64le and update versions#34
ralphtheninja merged 1 commit intorvagg:masterfrom
nagesh4193:master

Conversation

@nagesh4193
Copy link
Copy Markdown
Contributor

Added power support for the travis.yml file with ppc64le. This is part of the Ubuntu distribution for ppc64le. This helps us simplify testing later when distributions are re-building and re-releasing.

@ralphtheninja
Copy link
Copy Markdown
Collaborator

@rvagg What do you think about releasing v1.0.0 on this when dropping support for older node versions? Or just keep on publishing patches?

@rvagg
Copy link
Copy Markdown
Owner

rvagg commented Dec 14, 2020

Oh, I don't know. This is one of those dependencies that people don't want to have to think about and a major bump will have big ripple effects.
Maybe we do both? Accept this PR and then do a bump, dropping old versions. I think the ppc64le folks are doing ecosystem rollouts for RedHat dependencies so would probably be happy if changes like this were fairly minimal and non-disruptive and I'm OK with that. I've already had to merge at least one of these PRs in one of my repos and I expect more.

@ralphtheninja
Copy link
Copy Markdown
Collaborator

ralphtheninja commented Dec 14, 2020

@nagesh4193 Mind adding just the following snippet

arch:
  - amd64
  - ppc64le

And the new even node versions? I.e. do not remove the old node versions. Then we can accept your PR, release a new patch version. After this we can publish a new major version with the old node versions removed.

@nagesh4193
Copy link
Copy Markdown
Contributor Author

@ralphtheninja I have made the changes as requested by adding old travis node_js versions and new even versions. Please let me know, if any other changes are required from my end. Thanks.

@ralphtheninja
Copy link
Copy Markdown
Collaborator

@rvagg If you don't mind I'll release a new patch, then remove old node versions and release a new major. We can even keep a 0.x-branch around if need be later.

@rvagg
Copy link
Copy Markdown
Owner

rvagg commented Dec 16, 2020

sgtm, thanks!

@ralphtheninja ralphtheninja merged commit e2e9e6d into rvagg:master Dec 16, 2020
@ralphtheninja
Copy link
Copy Markdown
Collaborator

@nagesh4193 Published in v0.1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants