require quiescence sessions to be single-use#15
Closed
ProofOfKeags wants to merge 4 commits intorustyrussell:quiescence-protocolfrom
Closed
require quiescence sessions to be single-use#15ProofOfKeags wants to merge 4 commits intorustyrussell:quiescence-protocolfrom
ProofOfKeags wants to merge 4 commits intorustyrussell:quiescence-protocolfrom
Conversation
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This is especially useful for protocols such as splicing; for simplified commitment transactions, there is already an implied initiator at each point, so having the negotiation at splicing time would be redundant. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
In practice, sftu is useless unless you have something (e.g. channel_upgrade) which uses it, but adding a feature is best practice IMHO. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
23 tasks
t-bast
approved these changes
May 21, 2024
t-bast
left a comment
There was a problem hiding this comment.
LGTM, thanks @ProofOfKeags 👍
@rustyrussell can you apply this change and rebase the quiescence PR on top of bolts/master? Then it should be ready for inclusion to the BOLTs 🚀
a68d7b0 to
b474755
Compare
Author
|
Looks like these changes were applied already |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR clarifies that protocol that assume quiescence have the responsibility for defining the states that terminate quiescence. It also attempts to track the discussion that led to this decision as well as describing non-obvious properties that result from this design choice.