Skip to content

Fix passing relative paths to cargo#1331

Merged
drager merged 2 commits intodrager:masterfrom
dfaust:fix-target-dir
Jul 1, 2024
Merged

Fix passing relative paths to cargo#1331
drager merged 2 commits intodrager:masterfrom
dfaust:fix-target-dir

Conversation

@dfaust
Copy link
Contributor

@dfaust dfaust commented Sep 22, 2023

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

When building a crate located in a sub-directory, relative paths, passed as extra options to cargo (like --target-dir), are now handled correctly.

This closes issues #704, #1156 and #1252.
And makes PR #712 obsolete.

Copy link
Owner

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants