Fix error and warnings in install script#1320
Merged
drager merged 1 commit intodrager:masterfrom Nov 19, 2023
Merged
Conversation
- Fixed error on line 139 - "==" was being used, whereas sh expects a "=" (and we do this correctly throughout the rest of the file). See https://www.shellcheck.net/wiki/SC3014 for more. - Changed the use of backticks to the use of `$()` as specified in https://www.shellcheck.net/wiki/SC2006 - Changed the use of `-a` to `&&` as specified in https://www.shellcheck.net/wiki/SC2166 Closes drager#1159 Closes drager#1217 Closes drager#1283
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$()as specified in https://www.shellcheck.net/wiki/SC2006-ato&&as specified in https://www.shellcheck.net/wiki/SC2166Closes #1159
Closes #1217
Closes #1283
Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨