Skip to content

Restore --version command#1305

Merged
drager merged 1 commit intodrager:masterfrom
lynn:version-command
Jun 21, 2023
Merged

Restore --version command#1305
drager merged 1 commit intodrager:masterfrom
lynn:version-command

Conversation

@lynn
Copy link
Contributor

@lynn lynn commented Jun 19, 2023

Fixes #1301, which was introduced by 73e059f.

It prints wasm-pack 0.12.0, just like wasm-pack 0.11.0 printed wasm-pack 0.11.0. That is to say: clap 4 formats the version the same way as structopt. It also adds the same -V short alias that structopt does.

Copy link

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patch works for me.

Copy link
Owner

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@drager drager merged commit 8baa0b9 into drager:master Jun 21, 2023
@namse
Copy link

namse commented Jun 26, 2023

Have any plan to publish new version with this PR changes? unexpected --version error breaks ci/cd

@drager
Copy link
Owner

drager commented Jun 27, 2023

Have any plan to publish new version with this PR changes? unexpected --version error breaks ci/cd

Yep. Released now in v0.12.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unexpected argument --version found

4 participants