Fix getting the target-dir in wasm_bindgen_build#1279
Merged
drager merged 2 commits intodrager:masterfrom Jun 11, 2023
Merged
Conversation
0141e79 to
25ef942
Compare
ranile
reviewed
May 30, 2023
Contributor
ranile
left a comment
There was a problem hiding this comment.
Can you add a test case for this as well?
e3a5284 to
4190e54
Compare
Contributor
Author
@hamza1311 sure, I've added a test that panics on current master 3073db8 . |
ranile
reviewed
Jun 1, 2023
Contributor
ranile
left a comment
There was a problem hiding this comment.
Oops, didn't mean to approve. The CI is failing
Contributor
Author
|
I have seen the same failure in other actions as well, e.g. here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1278
The bug was caused by using binary_search on
extra_optionswhich is not sorted.Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submitting