Conversation
Contributor
Author
|
actually.... i'm not sure if this is needed since it looks like the release already happened and |
Owner
|
I actually merged your PR after I released 0.10.3. |
Contributor
Author
|
ah! ok! then in that case, this should likely be merged 🙈 |
drager
approved these changes
Jan 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hopefully we can get this in before the release happens otherwise i fear the npm installer may break! i meant to open this PR sooner but just never got around to it. this is the patch i submitted to the primary repo I work on for comparison to this PR.
We ended up burning two releases due to npm install woes, but things are working smoothly now. cc @drager