Use bash to create release tarballs#1144
Merged
drager merged 1 commit intodrager:masterfrom Jun 12, 2022
Merged
Conversation
|
@drager since this (hopefully! I haven't actually tested) the issue where wasm-pack is entirely broken on Windows as currently released, would it be possible to get this merged and released soon? Thank you! |
Owner
Yes! Will merge once CI passes :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1097 by using
bashto create the tarball on Windows.The issue was probably caused by the behaviour of the
|operator with the default shell (PowerShell on Windows runners I believe).