Add suppot for more platforms to installer script#1122
Merged
drager merged 1 commit intodrager:masterfrom Jun 13, 2022
Merged
Conversation
Contributor
|
There's a bunch of open issues about M1 support, should this be marked as closing some of them? https://github.com/rustwasm/wasm-pack/issues?q=is%3Aissue+is%3Aopen+m1 |
Author
|
Hi! Thanks for taking a look at this. It might help with #1064; I'll update the description |
Author
|
Seems to fail for unrelated reasons |
Author
|
Hi, @gthb, are you the right person to look into merging this, or do we just wait for it to get picked up by the maintainers? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the installation script work on M1 macs, as well as inside docker (especially when combined with buildx) for aarch64/arm64 architectures.
Related: