Skip to content

fix(#1076): --target-dir as extra option is now considered as expected#1082

Merged
drager merged 1 commit intodrager:masterfrom
sassman:fix/target-path-as-extra-args-issue-1076
Dec 14, 2022
Merged

fix(#1076): --target-dir as extra option is now considered as expected#1082
drager merged 1 commit intodrager:masterfrom
sassman:fix/target-path-as-extra-args-issue-1076

Conversation

@sassman
Copy link
Contributor

@sassman sassman commented Nov 17, 2021

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

@wdanilo
Copy link

wdanilo commented Dec 13, 2022

@drager - do you think we can merge it? It would save a lot of debugging on our end this week :(

@drager
Copy link
Owner

drager commented Dec 14, 2022

@drager - do you think we can merge it? It would save a lot of debugging on our end this week :(

Yes! I'll try to publish a new release this week as well.

Copy link
Owner

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@drager drager merged commit 9f909db into drager:master Dec 14, 2022
@wdanilo
Copy link

wdanilo commented Dec 15, 2022

Thanks so so so much @drager !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants