rustsec: Fix git2 via cargo-edit-9 fork#831
Conversation
|
I'll go ahead and ship it. |
|
It's fine, though I would like to finish getting the parts we need vendored, especially as they're useful for implementing other features |
|
There are other people who need this as well so I think keeping it as a crate but more for our purposes could work ? |
|
We only need a small subset of the functionality, and it currently has a lot of hard dependencies which are unnecessary for our purposes, which is why I have a WIP branch partly finished to extract the requisite functionality which also eliminates the need to feature-gate There are also private APIs it would be nice to have visible within the |
|
yeah the deps are a lot, I thought about vendoring and thought it's a lot of work and thought you might have something in the oven so temporary stopgap then What I meant more is that can we make it separate crate so we can offer this to others w/o having to use rustsec ? |
Fixes #830
Supercedes #801
packed_simd_2is similar how it's used. Can use this and gradually do something about it e.g. minify it for our purposes.I've worked 0.9 with dependency bumps to: https://github.com/pinkforest/cargo-edit-9
crates-index also has to be bumped to 0.19 that picks up 0.16 git2
This was according to recommendation here:
LocalManifest::upgrade? killercup/cargo-edit#837 (comment)