Skip to content

Relax git2 requirement#662

Merged
tarcieri merged 1 commit intorustsec:mainfrom
kornelski:gitv
Aug 27, 2022
Merged

Relax git2 requirement#662
tarcieri merged 1 commit intorustsec:mainfrom
kornelski:gitv

Conversation

@kornelski
Copy link
Copy Markdown
Contributor

Allows using git2 0.15 too

@alex
Copy link
Copy Markdown
Member

alex commented Aug 27, 2022

is there a reason not to just upgrade to 0.15?

@tarcieri
Copy link
Copy Markdown
Member

If it compiles with both, I think this requirement is OK.

However it would probably make sense to check it continues to compile with -Z minimal-versions if we do this.

@kornelski
Copy link
Copy Markdown
Contributor Author

git2 depends on libgit2-sys that has a links attribute, so only one version can exist in a program. git2 versions are fragmented now, so supporting both helps: https://lib.rs/crates/git2/rev

AFAIK there aren't any real breaking changes between the two versions, so allowing both is harmless.

@tarcieri tarcieri merged commit ab96b4f into rustsec:main Aug 27, 2022
@tarcieri
Copy link
Copy Markdown
Member

Cool, let's try it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants