zerocopy: Some Ref methods are unsound with some type params#1837
Merged
tarcieri merged 3 commits intorustsec:mainfrom Dec 18, 2023
Merged
zerocopy: Some Ref methods are unsound with some type params#1837tarcieri merged 3 commits intorustsec:mainfrom
tarcieri merged 3 commits intorustsec:mainfrom
Conversation
For more information: - google/zerocopy#716 - GHSA-3mv5-343c-w2qg
11 tasks
Contributor
Author
|
Re: CI failure: Is there a way to omit the version specifier for each function? All listed functions are affected in all crate versions affected by this advisory. |
Member
|
Unfortunately not, although once you write it once you can copy/paste |
Contributor
Author
tarcieri
reviewed
Dec 18, 2023
tarcieri
approved these changes
Dec 18, 2023
Member
|
Assigned |
Contributor
Author
|
Thanks for the review, @tarcieri! And apologies again about nagging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more information:
Ref<core::cell::Ref<[u8]>, _>::into_refis unsound google/zerocopy#716