Skip to content

Ignore wildcard labels when matching name constraints#468

Merged
djc merged 3 commits into
mainfrom
wildcard-constraint-fix
Apr 13, 2026
Merged

Ignore wildcard labels when matching name constraints#468
djc merged 3 commits into
mainfrom
wildcard-constraint-fix

Conversation

@djc

@djc djc commented Apr 13, 2026

Copy link
Copy Markdown
Member

Addresses an issue privately reported by @1seal, which we've decided to address in public.

@djc djc requested review from cpu and ctz April 13, 2026 13:45
@codecov

codecov Bot commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.73%. Comparing base (c36ee95) to head (8078d49).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
+ Coverage   96.71%   96.73%   +0.02%     
==========================================
  Files          20       20              
  Lines        3927     3954      +27     
==========================================
+ Hits         3798     3825      +27     
  Misses        129      129

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc djc force-pushed the wildcard-constraint-fix branch from 392082d to 412732b Compare April 13, 2026 14:18
@ctz

ctz commented Apr 13, 2026

Copy link
Copy Markdown
Member

7ab9802 has some extra tests. On main this looks like:

test wildcard_san_accepted_if_in_subtree ... ok
test wildcard_san_rejected_if_could_match_excluded_subtree ... ok
test wildcard_san_rejected_if_could_match_name_outside_permitted_subtree ... FAILED
test wildcard_san_rejected_if_in_excluded_subtree ... ok

On this branch, it looks like:

test wildcard_san_accepted_if_in_subtree ... ok
test wildcard_san_rejected_if_could_match_excluded_subtree ... FAILED
test wildcard_san_rejected_if_could_match_name_outside_permitted_subtree ... ok
test wildcard_san_rejected_if_in_excluded_subtree ... ok

@djc djc force-pushed the wildcard-constraint-fix branch 2 times, most recently from 0d01fad to 5abf123 Compare April 13, 2026 14:23
@djc djc force-pushed the wildcard-constraint-fix branch from 5abf123 to 8078d49 Compare April 13, 2026 14:27
@djc

djc commented Apr 13, 2026

Copy link
Copy Markdown
Member Author

On this branch, it looks like:

Should be better by now...

ctz
ctz approved these changes Apr 13, 2026
View reviewed changes

@ctz ctz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djc djc added this pull request to the merge queue Apr 13, 2026
Merged via the queue into main with commit 2c2d56b Apr 13, 2026
26 checks passed
@djc djc deleted the wildcard-constraint-fix branch April 13, 2026 14:41
@djc djc mentioned this pull request Apr 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctz ctz ctz approved these changes

@cpu cpu Awaiting requested review from cpu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@djc @ctz