Merged
Conversation
Merged
ctz
approved these changes
Mar 9, 2025
complexspaces
requested changes
Mar 9, 2025
Collaborator
complexspaces
left a comment
There was a problem hiding this comment.
I think we can ignore this because it's only used for testing and so it seems unlikely that someone in the wild depends on it.
I agree with this. The ffi-testing feature is explicitly documented as unstable/internal so it's not covered by the version's compatibility guarantees.
complexspaces
approved these changes
Mar 15, 2025
Collaborator
complexspaces
left a comment
There was a problem hiding this comment.
Sorry for the review time gap, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is technically semver-incompatible because it removes the
pastefeature. I think we can ignore this because it's only used for testing and so it seems unlikely that someone in the wild depends on it.