Ignore empty entries in SSL_CERT_DIR#242
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
a217f48 to
d4a4bd6
Compare
cpu
reviewed
May 29, 2026
38a771c to
a217f48
Compare
A leading or trailing separator (e.g. `:/etc/ssl/certs`) produces an
empty path component via `env::split_paths`, which then causes a
spurious ENOENT warning when `fs::read_dir("")` is called. Filter out
empty components before collecting so they are silently skipped.
Fixes rustls#241
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
a217f48 to
1a51788
Compare
ctz
approved these changes
May 30, 2026
djc
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A leading or trailing separator (e.g.
:/etc/ssl/certs) produces an empty path component viaenv::split_paths, which then causes a spurious ENOENT warning whenfs::read_dir("")is called. Filter out empty components before collecting so they are silently skipped.Fixes #241