-
Notifications
You must be signed in to change notification settings - Fork 780
Support P256+SHA512 and P384+SHA512 signatures in certificates #2827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Memory usageKey:
Significant differencesThere are no significant memory usage differences Additional informationCheckout details:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2827 +/- ##
=======================================
Coverage 93.92% 93.92%
=======================================
Files 99 99
Lines 21580 21597 +17
Branches 642 642
=======================================
+ Hits 20269 20286 +17
Misses 1168 1168
Partials 143 143 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Do you want to backport this to 0.23? |
This allows P256+SHA512 and P384+SHA512 signatures in certificates, when using the aws-lc-rs provider.
Previously, 0.23.32 added support for these in TLS1.2 handshake signatures. This was the topic of #2661 and #2477.
Note that (eg) Mozilla's Root Store Policy disallows such certificates. However, the reported case is a private CA, though the documentation for that CA also specifies that RSA keys are to be used? It's vibe certificates all the way down.
fixes #2825