Skip to content

Backport empty OCSP fix for 0.23.35 #2734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
djc merged 4 commits into from
Nov 4, 2025
Merged

Backport empty OCSP fix for 0.23.35 #2734

djc merged 4 commits into from
Nov 4, 2025

Conversation

@djc
Copy link
Member

@djc djc commented Nov 4, 2025

Backports

Proposed release notes

There was a regression in 0.23.23 and later where an empty value passed in ConfigBuilder::with_single_cert_with_ocsp() resulted in sending an empty OCSP value (instead of not sending anything). Thanks to @vuongDang for reporting and fixing.

@djc djc requested review from cpu and ctz November 4, 2025 13:48
@djc djc mentioned this pull request Nov 4, 2025
Merged
@djc djc changed the title Backport empty OCSP fix to 0.23.x Backport empty OCSP fix for 0.23.35 Nov 4, 2025
@djc djc enabled auto-merge November 4, 2025 13:51
@rustls-benchmarking
Copy link

rustls-benchmarking bot commented Nov 4, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1581167 1605417 ⚠️ 24250 (1.53%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3937639 3984731 ⚠️ 47092 (1.20%) 0.47%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11144595 11177782 33187 (0.30%) 1.03%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 52916742 53063643 146901 (0.28%) 0.41%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9149707 9171948 22241 (0.24%) 1.40%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11128410 11152691 24281 (0.22%) 1.27%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 52997905 52889061 -108844 (-0.21%) 0.43%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 52599058 52707021 107963 (0.21%) 0.73%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 52676202 52773858 97656 (0.19%) 0.59%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 53016870 52919826 -97044 (-0.18%) 0.43%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9157997 9174663 16666 (0.18%) 0.67%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 43939546 44001801 62255 (0.14%) 0.24%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 42502796 42557796 55000 (0.13%) 0.44%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 43952142 43898797 -53345 (-0.12%) 0.25%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 52712650 52774411 61761 (0.12%) 0.64%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 42587057 42636607 49550 (0.12%) 0.35%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 43987983 43940386 -47597 (-0.11%) 0.25%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 42549377 42579782 30405 (0.07%) 0.41%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 52865254 52902059 36805 (0.07%) 0.30%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 52895576 52932310 36734 (0.07%) 0.39%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3303384 3305601 2217 (0.07%) 0.23%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 43875462 43896380 20918 (0.05%) 0.23%
handshake_tickets_1.3_no_crypto_server 2071043 2072003 960 (0.05%) 0.20%
handshake_session_id_1.3_no_crypto_server 2107010 2107970 960 (0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 43918491 43937755 19264 (0.04%) 0.25%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 52706415 52719977 13562 (0.03%) 0.54%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 42605103 42612936 7833 (0.02%) 0.33%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2484242 2484529 287 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1578697 1578611 -86 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3935692 3935873 181 (0.00%) 0.24%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 42625794 42627209 1415 (0.00%) 0.34%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2772565 2772477 -88 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2487372 2487448 76 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31513873 31514833 960 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31516652 31517612 960 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31516944 31517904 960 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 31635853 31636813 960 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 31638632 31639592 960 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 31638924 31639884 960 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 31971812 31972772 960 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 31974557 31975517 960 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 31974608 31975568 960 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32074052 32075012 960 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32076797 32077757 960 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32076848 32077808 960 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2765375 2765457 82 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 42551023 42552047 1024 (0.00%) 0.24%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10435420 10435626 206 (0.00%) 0.81%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 52889738 52888851 -887 (-0.00%) 0.46%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 43896421 43896998 577 (0.00%) 0.27%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 52771049 52771676 627 (0.00%) 0.57%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 52701514 52702054 540 (0.00%) 0.40%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3306852 3306822 -30 (-0.00%) 0.27%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1285307 1285303 -4 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1721495 1721491 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46129346 46129338 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58016636 58016626 -10 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57921268 57921277 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92592148 92592159 11 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80252333 80252342 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80360274 80360265 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46190731 46190726 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92552697 92552706 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58131996 58131991 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58072174 58072178 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58141991 58141994 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46022419 46022417 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46179788 46179786 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92603452 92603448 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58025339 58025337 -2 (-0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 117361610 117361606 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80257305 80257307 2 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 45922785 45922784 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46014271 46014272 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46015534 46015533 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46177824 46177825 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92542711 92542713 2 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104989399 104989397 -2 (-0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_server 105034445 105034443 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58028257 58028258 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58142008 58142009 1 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 117312741 117312743 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80357660 80357661 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92602150 92602149 -1 (-0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4162880 4162880 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30393307 30393307 0 (0.00%) 0.20%
handshake_tickets_1.2_no_crypto_server 1209521 1209521 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1286491 1286491 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3899027 3899027 0 (0.00%) 0.20%
handshake_tickets_1.3_no_crypto_client 2215268 2215268 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34736031 34736031 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2242718 2242718 0 (0.00%) 0.20%
handshake_no_resume_1.2_no_crypto_client 98321 98321 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30294775 30294775 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10987633 10987633 0 (0.00%) 0.20%
handshake_no_resume_1.3_no_crypto_client 111760 111760 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4617074 4617074 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80249157 80249157 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30301657 30301657 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4230931 4230931 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 30619957 30619957 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30297543 30297543 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 30555716 30555716 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4980598 4980598 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 30623243 30623243 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 30551612 30551612 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34737743 34737743 0 (0.00%) 0.20%
handshake_session_id_1.2_no_crypto_client 1151062 1151062 0 (0.00%) 0.20%
handshake_no_resume_1.3_no_crypto_server 98264 98264 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11114608 11114608 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11108845 11108845 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 30627347 30627347 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4490321 4490321 0 (0.00%) 0.20%
handshake_session_id_1.3_no_crypto_client 2196722 2196722 0 (0.00%) 0.20%
handshake_session_id_1.2_no_crypto_server 1049211 1049211 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 30548347 30548347 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3823101 3823101 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2332734 2332734 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80371216 80371216 0 (0.00%) 0.20%
handshake_tickets_1.2_no_crypto_client 1238324 1238324 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4237416 4237416 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92554343 92554343 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7210935 7210935 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7208974 7208974 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30389193 30389193 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30386425 30386425 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2338388 2338388 0 (0.00%) 0.20%
handshake_no_resume_1.2_no_crypto_server 74754 74754 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_1.3_no_crypto 81.94 µs 84.82 µs 2.88 µs (3.51%) 11.83%
handshake_no_resume_1.2_no_crypto 74.28 µs 76.87 µs 2.59 µs (3.48%) 9.81%
handshake_tickets_1.3_no_crypto 607.50 µs 625.00 µs 17.50 µs (2.88%) 5.13%
handshake_session_id_1.3_no_crypto 630.79 µs 646.27 µs 15.47 µs (2.45%) 3.84%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.48 ms 4.56 ms 0.08 ms (1.89%) 3.96%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.17 ms 5.25 ms 0.08 ms (1.62%) 4.11%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.15 ms 5.23 ms 0.08 ms (1.57%) 3.08%
handshake_session_id_1.2_no_crypto 335.63 µs 340.73 µs 5.10 µs (1.52%) 9.20%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.30 ms 5.38 ms 0.08 ms (1.52%) 3.38%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 4.99 ms 5.06 ms 0.07 ms (1.42%) 2.67%
transfer_no_resume_ring_1.3_rsa_aes 5.78 ms 5.86 ms 0.08 ms (1.32%) 3.52%
transfer_no_resume_ring_1.2_rsa_aes 5.72 ms 5.78 ms 0.07 ms (1.15%) 3.18%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 533.42 µs 539.46 µs 6.04 µs (1.13%) 2.90%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 535.61 µs 541.57 µs 5.96 µs (1.11%) 3.91%
handshake_no_resume_ring_1.3_ecdsap256_chacha 453.61 µs 458.30 µs 4.69 µs (1.03%) 2.42%
handshake_no_resume_ring_1.3_ecdsap256_aes 456.33 µs 461.02 µs 4.69 µs (1.03%) 2.95%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.39 ms 8.47 ms 0.08 ms (0.91%) 2.70%
transfer_no_resume_1.3_no_crypto 11.82 ms 11.91 ms 0.10 ms (0.81%) 2.55%
handshake_tickets_1.2_no_crypto 376.31 µs 373.65 µs -2.65 µs (-0.71%) 4.96%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.19 ms 1.20 ms 0.01 ms (0.68%) 1.15%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.95 ms 13.03 ms 0.08 ms (0.63%) 1.76%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.64 ms 13.72 ms 0.08 ms (0.59%) 1.50%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.86 ms 12.93 ms 0.07 ms (0.58%) 1.79%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.63 ms 13.71 ms 0.08 ms (0.56%) 1.56%
transfer_no_resume_ring_1.3_rsa_chacha 13.35 ms 13.42 ms 0.07 ms (0.55%) 1.35%
transfer_no_resume_ring_1.3_ecdsap384_chacha 15.95 ms 16.03 ms 0.08 ms (0.51%) 1.38%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.07 ms 1.07 ms 0.01 ms (0.49%) 1.87%
transfer_no_resume_1.2_no_crypto 11.83 ms 11.89 ms 0.06 ms (0.48%) 1.80%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.20 ms 1.21 ms 0.01 ms (0.48%) 1.44%
handshake_no_resume_ring_1.3_rsa_chacha 945.58 µs 949.64 µs 4.07 µs (0.43%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.42 ms 5.45 ms 0.02 ms (0.41%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 945.45 µs 949.26 µs 3.81 µs (0.40%) 1.18%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.22 ms 1.22 ms 0.00 ms (0.40%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 7.27 ms 7.29 ms 0.03 ms (0.37%) 1.21%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 7.25 ms 7.27 ms 0.03 ms (0.37%) 1.48%
handshake_no_resume_ring_1.2_rsa_aes 939.57 µs 942.92 µs 3.35 µs (0.36%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.62 ms 1.62 ms 0.01 ms (0.35%) 1.58%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 7.44 ms 7.47 ms 0.03 ms (0.34%) 1.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.22 ms 1.23 ms 0.00 ms (0.34%) 1.38%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.45 ms 5.47 ms 0.02 ms (0.32%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 7.92 ms 7.95 ms 0.03 ms (0.32%) 1.48%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 7.95 ms 7.97 ms 0.03 ms (0.32%) 1.39%
handshake_session_id_ring_1.3_rsa_aes 5.92 ms 5.93 ms 0.02 ms (0.32%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.49 ms 5.51 ms 0.02 ms (0.31%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 5.94 ms 5.96 ms 0.02 ms (0.31%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 5.88 ms 5.90 ms 0.02 ms (0.31%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.39 ms 5.41 ms 0.02 ms (0.29%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 8.13 ms 8.15 ms 0.02 ms (0.27%) 1.37%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 7.92 ms 7.95 ms 0.02 ms (0.27%) 1.04%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 7.95 ms 7.97 ms 0.02 ms (0.26%) 1.22%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 8.14 ms 8.16 ms 0.02 ms (0.26%) 1.34%
handshake_tickets_ring_1.3_rsa_aes 5.98 ms 5.99 ms 0.02 ms (0.25%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.58 ms 8.60 ms 0.02 ms (0.24%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.55 ms 8.57 ms 0.02 ms (0.22%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.51 ms 8.53 ms 0.02 ms (0.22%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 8.12 ms 8.14 ms 0.02 ms (0.20%) 1.33%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 7.44 ms 7.45 ms 0.01 ms (0.15%) 1.20%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.48 ms 8.50 ms 0.01 ms (0.15%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 8.13 ms 8.14 ms 0.01 ms (0.13%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.55 ms 3.56 ms 0.00 ms (0.12%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.55 ms 3.55 ms 0.00 ms (0.10%) 1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.78 ms 1.78 ms 0.00 ms (0.07%) 2.02%
handshake_tickets_ring_1.2_rsa_aes 1.54 ms 1.54 ms -0.00 ms (-0.02%) 2.04%
handshake_session_id_ring_1.2_rsa_aes 1.46 ms 1.46 ms -0.00 ms (-0.00%) 1.85%

Additional information

Historical results

Checkout details:

@codecov
Copy link

codecov bot commented Nov 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.22%. Comparing base (4cee226) to head (e0f054d).
⚠️ Report is 4 commits behind head on rel-0.23.

Additional details and impacted files 
@@             Coverage Diff              @@
##           rel-0.23    #2734      +/-   ##
============================================
+ Coverage     95.19%   95.22%   +0.02%     
============================================
  Files            97       97              
  Lines         21890    21880      -10     
============================================
- Hits          20839    20835       -4     
+ Misses         1051     1045       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc djc force-pushed the 0.23-empty-ocsp branch from 687fc80 to e0f054d Compare November 4, 2025 14:14
@djc djc added this pull request to the merge queue Nov 4, 2025
Merged via the queue into rel-0.23 with commit 7768cd2 Nov 4, 2025
34 checks passed
@djc djc deleted the 0.23-empty-ocsp branch November 4, 2025 14:33
@djc
Copy link
Member Author

djc commented Nov 4, 2025

  • Published rustls v0.23.35 at registry crates-io
  • [new tag] v/0.23.35 -> v/0.23.35
  • Release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctz ctz ctz approved these changes

@cpu cpu Awaiting requested review from cpu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@djc @ctz @vuongDang