Skip to content

Separate resumption across security domains (redux)#2722

Merged
ctz merged 12 commits intomainfrom
jbp-client-storage-key
Nov 27, 2025
Merged

Separate resumption across security domains (redux)#2722
ctz merged 12 commits intomainfrom
jbp-client-storage-key

Conversation

@ctz
Copy link
Member

@ctz ctz commented Oct 23, 2025

This is a different approach to solving #2284 and effectively reverts #2361. It is actually described in that bug (the paragraph starting "The best behaviour ...") but that wasn't possible at the time.

This is a draft -- looking for any thoughts on the overall approach rather than any details at this point. Relies on some (non-breaking) changes in pki-types and webpki too.

@ctz ctz changed the title Separate Separate resumption across security domains (redux) Oct 23, 2025
@rustls-benchmarking
Copy link

rustls-benchmarking bot commented Oct 23, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2671474 2631722 ✅ -39752 (-1.49%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_1.2_no_crypto_client 62391 61792 -599 (-0.96%) 0.97%
handshake_tickets_1.3_no_crypto_client 2397145 2413887 16742 (0.70%) 0.87%
handshake_session_id_1.2_no_crypto_client 1222881 1230147 7266 (0.59%) 1.03%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11041124 11100471 59347 (0.54%) 1.15%
handshake_no_resume_1.3_no_crypto_client 72958 72577 -381 (-0.52%) 0.76%
handshake_session_id_1.3_no_crypto_client 2382046 2394352 12306 (0.52%) 0.83%
handshake_tickets_1.2_no_crypto_client 1309131 1315313 6182 (0.47%) 0.87%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 50249876 50434996 185120 (0.37%) 0.73%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 50041744 50179822 138078 (0.28%) 0.43%
handshake_session_id_ring_1.2_rsa_aes_client 3525918 3535470 9552 (0.27%) 0.34%
handshake_tickets_ring_1.2_rsa_aes_server 3998911 3990395 -8516 (-0.21%) 0.45%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11077469 11099884 22415 (0.20%) 0.63%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 50248185 50345176 96991 (0.19%) 0.61%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 43022559 43102996 80437 (0.19%) 0.50%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 50063217 50148732 85515 (0.17%) 0.71%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 50159301 50238262 78961 (0.16%) 0.52%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 50334045 50412794 78749 (0.16%) 0.65%
handshake_tickets_ring_1.3_rsa_chacha_client 30680697 30724884 44187 (0.14%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 30752907 30797094 44187 (0.14%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 50357658 50286412 -71246 (-0.14%) 0.71%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 41646126 41703785 57659 (0.14%) 0.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9040379 9028105 -12274 (-0.14%) 1.09%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 50156991 50092587 -64404 (-0.13%) 0.38%
handshake_tickets_ring_1.2_rsa_aes_client 3920511 3925038 4527 (0.12%) 0.41%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30570606 30603631 33025 (0.11%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30662276 30695311 33035 (0.11%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 43023008 43067108 44100 (0.10%) 0.28%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 41747451 41705160 -42291 (-0.10%) 0.25%
handshake_session_id_ring_1.3_rsa_chacha_client 30570233 30599547 29314 (0.10%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30661883 30691197 29314 (0.10%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 42993810 42953623 -40187 (-0.09%) 0.40%
handshake_no_resume_1.3_no_crypto_server 64298 64243 -55 (-0.09%) 1.02%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9012483 9020103 7620 (0.08%) 1.25%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4342396 4345976 3580 (0.08%) 0.28%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4967078 4971128 4050 (0.08%) 0.55%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 43034986 43064800 29814 (0.07%) 0.33%
handshake_tickets_1.2_no_crypto_server 1289129 1288259 -870 (-0.07%) 1.28%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 50287267 50256781 -30486 (-0.06%) 0.41%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46037203 46010794 -26409 (-0.06%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46027918 46001678 -26240 (-0.06%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46028209 46001969 -26240 (-0.06%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30574326 30591671 17345 (0.06%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30666006 30683341 17335 (0.06%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 41649212 41672067 22855 (0.05%) 0.37%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 41668140 41646086 -22054 (-0.05%) 0.35%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 30674747 30689747 15000 (0.05%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 30746977 30761987 15010 (0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 50096328 50072656 -23672 (-0.05%) 0.47%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 41705797 41722931 17134 (0.04%) 0.47%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3804401 3802923 -1478 (-0.04%) 4.05%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3950023 3951523 1500 (0.04%) 0.28%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 57985904 57964052 -21852 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 41595498 41579921 -15577 (-0.04%) 0.38%
handshake_session_id_ring_1.3_rsa_chacha_server 31724837 31713096 -11741 (-0.04%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 31847027 31835286 -11741 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 50337806 50355787 17981 (0.04%) 0.73%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 50149616 50167137 17521 (0.03%) 0.66%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80208398 80182158 -26240 (-0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80208689 80182449 -26240 (-0.03%) 0.20%
handshake_no_resume_1.2_no_crypto_server 43030 43016 -14 (-0.03%) 0.89%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80218794 80192723 -26071 (-0.03%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2301546 2300894 -652 (-0.03%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2307198 2306545 -653 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1489722 1489344 -378 (-0.03%) 5.25%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 30688706 30681071 -7635 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 30760946 30753301 -7645 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92446064 92424212 -21852 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3272963 3272302 -661 (-0.02%) 0.23%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3274273 3273631 -642 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1487240 1486956 -284 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 42904531 42910439 5908 (0.01%) 0.31%
handshake_no_resume_ring_1.2_rsa_aes_server 10929532 10928136 -1396 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32009806 32013851 4045 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32112811 32116811 4000 (0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2176270 2176008 -262 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 43039465 43044235 4770 (0.01%) 0.35%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1686162 1685981 -181 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3849825 3850215 390 (0.01%) 0.84%
handshake_session_id_1.2_no_crypto_server 1141861 1141951 90 (0.01%) 1.36%
handshake_session_id_ring_1.2_rsa_aes_server 3427175 3426922 -253 (-0.01%) 0.33%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2625084 2624892 -192 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 45958514 45955594 -2920 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2409333 2409230 -103 (-0.00%) 0.20%
handshake_tickets_1.3_no_crypto_server 2225023 2224933 -90 (-0.00%) 0.60%
handshake_session_id_1.3_no_crypto_server 2265752 2265662 -90 (-0.00%) 0.84%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3799256 3799386 130 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10433366 10433012 -354 (-0.00%) 0.86%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2412409 2412479 70 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1238858 1238823 -35 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1237673 1237646 -27 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34713542 34712962 -580 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34715241 34714698 -543 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11085007 11084837 -170 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11090761 11090593 -168 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 57870484 57869844 -640 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31723194 31723524 330 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 31845384 31845714 330 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31728379 31728679 300 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 31850569 31850869 300 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32015852 32016152 300 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32023575 32023875 300 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32118812 32119112 300 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32126580 32126880 300 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57726920 57727458 538 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 45843781 45843538 -243 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7185601 7185571 -30 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 45922596 45922472 -124 (-0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 116952399 116952179 -220 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80157476 80157352 -124 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 57975061 57974988 -73 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92435221 92435148 -73 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 57905767 57905789 22 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 57975070 57975058 -12 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7187537 7187536 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92435230 92435218 -12 (-0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 116993684 116993695 11 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 45921844 45921844 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92395935 92395935 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92395935 92395935 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 45921623 45921623 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 57869855 57869855 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80157364 80157364 0 (0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_server 104867708 104867708 0 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104828238 104828238 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 57869855 57869855 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92395924 92395924 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80157143 80157143 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_1.2_no_crypto 377.86 µs 390.53 µs 12.67 µs (3.35%) 5.00%
handshake_tickets_1.2_no_crypto 411.01 µs 418.83 µs 7.83 µs (1.90%) 4.26%
transfer_no_resume_1.2_no_crypto 12.22 ms 12.05 ms -0.17 ms (-1.40%) 2.41%
handshake_no_resume_1.3_no_crypto 88.11 µs 89.29 µs 1.18 µs (1.34%) 9.62%
handshake_session_id_ring_1.2_rsa_aes 1.46 ms 1.48 ms 0.02 ms (1.29%) 1.55%
transfer_no_resume_1.3_no_crypto 12.27 ms 12.13 ms -0.14 ms (-1.12%) 2.48%
handshake_tickets_ring_1.2_rsa_aes 1.55 ms 1.57 ms 0.02 ms (1.10%) 1.79%
handshake_no_resume_1.2_no_crypto 79.65 µs 80.51 µs 0.87 µs (1.09%) 12.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.64 ms 1.66 ms 0.02 ms (1.00%) 1.99%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.81 ms 1.82 ms 0.01 ms (0.82%) 2.89%
handshake_no_resume_ring_1.3_ecdsap256_aes 464.13 µs 467.60 µs 3.47 µs (0.75%) 3.34%
handshake_no_resume_ring_1.3_ecdsap256_chacha 461.96 µs 465.21 µs 3.25 µs (0.70%) 2.92%
handshake_session_id_1.3_no_crypto 754.07 µs 750.01 µs -4.06 µs (-0.54%) 4.17%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 546.54 µs 549.13 µs 2.59 µs (0.47%) 3.46%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.18 ms 1.18 ms 0.01 ms (0.46%) 1.49%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 545.09 µs 547.28 µs 2.19 µs (0.40%) 3.74%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.73 ms 5.75 ms 0.02 ms (0.35%) 4.87%
handshake_no_resume_ring_1.3_rsa_chacha 956.00 µs 959.08 µs 3.08 µs (0.32%) 1.05%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.18 ms 1.18 ms 0.00 ms (0.30%) 1.88%
handshake_no_resume_ring_1.2_rsa_aes 945.58 µs 948.36 µs 2.79 µs (0.29%) 1.28%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 8.13 ms 8.11 ms -0.02 ms (-0.29%) 1.95%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.05 ms 1.06 ms 0.00 ms (0.28%) 1.62%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.23 ms 1.23 ms 0.00 ms (0.24%) 1.45%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.57 ms 3.56 ms -0.01 ms (-0.24%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.66 ms 8.64 ms -0.02 ms (-0.22%) 1.07%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.23 ms 1.23 ms 0.00 ms (0.21%) 1.66%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.62 ms 5.61 ms -0.01 ms (-0.21%) 5.24%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.57 ms 5.55 ms -0.01 ms (-0.20%) 4.65%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.37 ms 5.36 ms -0.01 ms (-0.20%) 4.72%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.93 ms 4.92 ms -0.01 ms (-0.19%) 6.07%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.56 ms 3.56 ms -0.01 ms (-0.18%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 954.07 µs 955.76 µs 1.69 µs (0.18%) 1.29%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 7.47 ms 7.45 ms -0.01 ms (-0.17%) 2.21%
handshake_tickets_ring_1.3_ecdsap384_aes 8.70 ms 8.69 ms -0.01 ms (-0.14%) 1.13%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.56 ms 5.55 ms -0.01 ms (-0.14%) 1.46%
handshake_tickets_ring_1.3_rsa_chacha 6.06 ms 6.05 ms -0.01 ms (-0.13%) 1.44%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.30 ms 13.32 ms 0.02 ms (0.13%) 1.96%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.61 ms 8.60 ms -0.01 ms (-0.13%) 1.26%
transfer_no_resume_ring_1.3_rsa_aes 6.22 ms 6.23 ms 0.01 ms (0.13%) 4.29%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 8.09 ms 8.08 ms -0.01 ms (-0.12%) 1.61%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 8.12 ms 8.11 ms -0.01 ms (-0.12%) 1.42%
transfer_no_resume_ring_1.3_rsa_chacha 13.79 ms 13.81 ms 0.01 ms (0.11%) 1.97%
handshake_tickets_ring_1.3_rsa_aes 6.10 ms 6.09 ms -0.01 ms (-0.10%) 1.30%
handshake_tickets_1.3_no_crypto 724.73 µs 724.02 µs -0.71 µs (-0.10%) 4.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 8.14 ms 8.13 ms -0.01 ms (-0.09%) 1.83%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.82 ms 8.83 ms 0.01 ms (0.09%) 2.97%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 7.65 ms 7.66 ms 0.01 ms (0.08%) 1.77%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.51 ms 5.51 ms -0.00 ms (-0.08%) 1.50%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 7.64 ms 7.64 ms 0.01 ms (0.08%) 1.68%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 8.31 ms 8.30 ms -0.01 ms (-0.08%) 1.66%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 14.06 ms 14.05 ms -0.01 ms (-0.07%) 1.99%
handshake_tickets_ring_1.3_ecdsap256_aes 5.60 ms 5.60 ms -0.00 ms (-0.07%) 1.34%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 8.34 ms 8.35 ms 0.01 ms (0.07%) 1.55%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 7.44 ms 7.43 ms -0.01 ms (-0.07%) 1.72%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.42 ms 13.41 ms -0.01 ms (-0.06%) 2.01%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 14.10 ms 14.10 ms -0.01 ms (-0.06%) 1.91%
handshake_session_id_ring_1.3_rsa_aes 6.05 ms 6.05 ms 0.00 ms (0.06%) 1.69%
handshake_session_id_ring_1.3_ecdsap384_aes 8.64 ms 8.64 ms -0.00 ms (-0.05%) 1.15%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 8.32 ms 8.33 ms 0.00 ms (0.04%) 1.68%
handshake_session_id_ring_1.3_ecdsap256_aes 5.55 ms 5.55 ms -0.00 ms (-0.04%) 1.39%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 8.29 ms 8.29 ms 0.00 ms (0.02%) 1.43%
transfer_no_resume_ring_1.2_rsa_aes 6.11 ms 6.11 ms 0.00 ms (0.01%) 3.91%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.41 ms 16.41 ms 0.00 ms (0.01%) 1.59%
handshake_session_id_ring_1.3_rsa_chacha 6.01 ms 6.01 ms -0.00 ms (-0.00%) 1.57%

Memory usage

Key:

  • ∑: sum usage for entire benchmark run
  • 🔝: peak usage
  • B: bytes
  • a: allocations

Significant differences

⚠️ There are significant memory usage differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_ring_1.2_rsa_aes_server ∑ 156004B 569a
🔝 59336B 202a		 ∑ 148692B 556a
🔝 59336B 202a		 ✅ ∑ -7312B -13a
🔝 +0B +0a (-4.69%)		 0.10%
handshake_no_resume_ring_1.3_rsa_aes_server ∑ 159253B 592a
🔝 59336B 202a		 ∑ 151941B 579a
🔝 59336B 202a		 ✅ ∑ -7312B -13a
🔝 +0B +0a (-4.59%)		 0.10%
handshake_no_resume_ring_1.3_rsa_chacha_server ∑ 159255B 592a
🔝 59336B 202a		 ∑ 151943B 579a
🔝 59336B 202a		 ✅ ∑ -7312B -13a
🔝 +0B +0a (-4.59%)		 0.10%
handshake_no_resume_ring_1.2_rsa_aes_client ∑ 130936B 564a
🔝 45309B 276a		 ∑ 124940B 554a
🔝 45309B 276a		 ✅ ∑ -5996B -10a
🔝 +0B +0a (-4.58%)		 0.10%
handshake_no_resume_ring_1.3_rsa_aes_client ∑ 133858B 560a
🔝 45309B 276a		 ∑ 128022B 550a
🔝 45309B 276a		 ✅ ∑ -5836B -10a
🔝 +0B +0a (-4.36%)		 0.10%
handshake_no_resume_ring_1.3_rsa_chacha_client ∑ 133860B 560a
🔝 45311B 276a		 ∑ 128024B 550a
🔝 45311B 276a		 ✅ ∑ -5836B -10a
🔝 +0B +0a (-4.36%)		 0.10%
handshake_tickets_ring_1.2_rsa_aes_server ∑ 170075B 665a
🔝 74424B 221a		 ∑ 162763B 652a
🔝 74424B 221a		 ✅ ∑ -7312B -13a
🔝 +0B +0a (-4.30%)		 0.10%
handshake_tickets_ring_1.3_rsa_aes_server ∑ 180120B 727a
🔝 75533B 228a		 ∑ 172808B 714a
🔝 75533B 228a		 ✅ ∑ -7312B -13a
🔝 +0B +0a (-4.06%)		 0.10%
handshake_tickets_ring_1.3_rsa_chacha_server ∑ 180122B 727a
🔝 75533B 228a		 ∑ 172810B 714a
🔝 75533B 228a		 ✅ ∑ -7312B -13a
🔝 +0B +0a (-4.06%)		 0.10%
handshake_session_id_ring_1.2_rsa_aes_server ∑ 183221B 639a
🔝 75056B 204a		 ∑ 175909B 626a
🔝 75056B 204a		 ✅ ∑ -7312B -13a
🔝 +0B +0a (-3.99%)		 0.10%
handshake_session_id_ring_1.3_rsa_aes_server ∑ 193588B 731a
🔝 75056B 204a		 ∑ 186276B 718a
🔝 75056B 204a		 ✅ ∑ -7312B -13a
🔝 +0B +0a (-3.78%)		 0.10%
handshake_session_id_ring_1.3_rsa_chacha_server ∑ 193590B 731a
🔝 75056B 204a		 ∑ 186278B 718a
🔝 75056B 204a		 ✅ ∑ -7312B -13a
🔝 +0B +0a (-3.78%)		 0.10%
handshake_session_id_ring_1.2_rsa_aes_client ∑ 160740B 634a
🔝 50402B 219a		 ∑ 155000B 624a
🔝 51248B 191a		 ✅ ∑ -5740B -10a
🔝 +846B -28a (-3.57%)		 0.10%
handshake_tickets_ring_1.2_rsa_aes_client ∑ 162372B 639a
🔝 50682B 222a		 ∑ 156632B 629a
🔝 51248B 191a		 ✅ ∑ -5740B -10a
🔝 +566B -31a (-3.54%)		 0.10%
handshake_session_id_ring_1.3_rsa_aes_client ∑ 176229B 696a
🔝 52580B 227a		 ∑ 170713B 686a
🔝 52900B 227a		 ✅ ∑ -5516B -10a
🔝 +320B +0a (-3.13%)		 0.10%
handshake_session_id_ring_1.3_rsa_chacha_client ∑ 176231B 696a
🔝 52580B 227a		 ∑ 170715B 686a
🔝 52900B 227a		 ✅ ∑ -5516B -10a
🔝 +320B +0a (-3.13%)		 0.10%
handshake_tickets_ring_1.3_rsa_aes_client ∑ 178053B 698a
🔝 52808B 227a		 ∑ 172537B 688a
🔝 53128B 227a		 ✅ ∑ -5516B -10a
🔝 +320B +0a (-3.10%)		 0.10%
handshake_tickets_ring_1.3_rsa_chacha_client ∑ 178055B 698a
🔝 52808B 227a		 ∑ 172539B 688a
🔝 53128B 227a		 ✅ ∑ -5516B -10a
🔝 +320B +0a (-3.10%)		 0.10%
handshake_no_resume_ring_1.3_ecdsap256_aes_server ∑ 137888B 566a
🔝 56484B 192a		 ∑ 134672B 555a
🔝 56484B 192a		 ✅ ∑ -3216B -11a
🔝 +0B +0a (-2.33%)		 0.10%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server ∑ 137893B 566a
🔝 56484B 192a		 ∑ 134677B 555a
🔝 56484B 192a		 ✅ ∑ -3216B -11a
🔝 +0B +0a (-2.33%)		 0.10%
handshake_no_resume_ring_1.3_ecdsap384_aes_server ∑ 139113B 566a
🔝 56664B 192a		 ∑ 135894B 555a
🔝 56664B 192a		 ✅ ∑ -3219B -11a
🔝 +0B +0a (-2.31%)		 0.10%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server ∑ 139110B 566a
🔝 56664B 192a		 ∑ 135894B 555a
🔝 56664B 192a		 ✅ ∑ -3216B -11a
🔝 +0B +0a (-2.31%)		 0.10%
handshake_tickets_ring_1.3_ecdsap256_chacha_server ∑ 158741B 701a
🔝 69743B 218a		 ∑ 155525B 690a
🔝 69743B 218a		 ✅ ∑ -3216B -11a
🔝 +0B +0a (-2.03%)		 0.10%
handshake_tickets_ring_1.3_ecdsap256_aes_server ∑ 158741B 701a
🔝 69743B 218a		 ∑ 155525B 690a
🔝 69743B 218a		 ✅ ∑ -3216B -11a
🔝 +0B +0a (-2.03%)		 0.10%
handshake_tickets_ring_1.3_ecdsap384_aes_server ∑ 159958B 701a
🔝 70374B 218a		 ∑ 156742B 690a
🔝 70374B 218a		 ✅ ∑ -3216B -11a
🔝 +0B +0a (-2.01%)		 0.10%
handshake_tickets_ring_1.3_ecdsap384_chacha_server ∑ 159958B 701a
🔝 70374B 218a		 ∑ 156742B 690a
🔝 70374B 218a		 ✅ ∑ -3216B -11a
🔝 +0B +0a (-2.01%)		 0.10%
handshake_session_id_ring_1.3_ecdsap256_chacha_server ∑ 172212B 705a
🔝 72204B 194a		 ∑ 168993B 694a
🔝 72204B 194a		 ✅ ∑ -3219B -11a
🔝 +0B +0a (-1.87%)		 0.10%
handshake_session_id_ring_1.3_ecdsap256_aes_server ∑ 172204B 705a
🔝 72204B 194a		 ∑ 168994B 694a
🔝 72204B 194a		 ✅ ∑ -3210B -11a
🔝 +0B +0a (-1.86%)		 0.10%
handshake_session_id_ring_1.3_ecdsap384_aes_server ∑ 173429B 705a
🔝 72384B 194a		 ∑ 170213B 694a
🔝 72384B 194a		 ✅ ∑ -3216B -11a
🔝 +0B +0a (-1.85%)		 0.10%
handshake_session_id_ring_1.3_ecdsap384_chacha_server ∑ 173426B 705a
🔝 72384B 194a		 ∑ 170216B 694a
🔝 72384B 194a		 ✅ ∑ -3210B -11a
🔝 +0B +0a (-1.85%)		 0.10%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server ∑ 443851B 690a
🔝 192352B 219a		 ∑ 436539B 677a
🔝 192352B 219a		 ✅ ∑ -7312B -13a
🔝 +0B +0a (-1.65%)		 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server ∑ 512225B 1019a
🔝 219800B 309a		 ∑ 503801B 998a
🔝 219040B 303a		 ✅ ∑ -8424B -21a
🔝 -760B -6a (-1.64%)		 0.87%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server ∑ 520405B 1005a
🔝 208072B 221a		 ∑ 511981B 984a
🔝 208072B 221a		 ✅ ∑ -8424B -21a
🔝 +0B +0a (-1.62%)		 0.86%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server ∑ 520477B 1005a
🔝 208072B 221a		 ∑ 512053B 984a
🔝 208072B 221a		 ✅ ∑ -8424B -21a
🔝 +0B +0a (-1.62%)		 0.85%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server ∑ 464354B 765a
🔝 192352B 219a		 ∑ 457042B 752a
🔝 192352B 219a		 ✅ ∑ -7312B -13a
🔝 +0B +0a (-1.57%)		 0.96%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server ∑ 465434B 773a
🔝 192352B 219a		 ∑ 458122B 760a
🔝 192352B 219a		 ✅ ∑ -7312B -13a
🔝 +0B +0a (-1.57%)		 0.96%
handshake_no_resume_ring_1.3_ecdsap256_aes_client ∑ 120740B 542a
🔝 45309B 276a		 ∑ 119000B 534a
🔝 45309B 276a		 ✅ ∑ -1740B -8a
🔝 +0B +0a (-1.44%)		 0.10%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client ∑ 120743B 542a
🔝 45311B 276a		 ∑ 119003B 534a
🔝 45311B 276a		 ✅ ∑ -1740B -8a
🔝 +0B +0a (-1.44%)		 0.10%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client ∑ 419075B 692a
🔝 173960B 197a		 ∑ 413047B 683a
🔝 174984B 197a		 ✅ ∑ -6028B -9a
🔝 +1024B +0a (-1.44%)		 0.10%
handshake_no_resume_ring_1.3_ecdsap384_aes_client ∑ 121275B 546a
🔝 45311B 276a		 ∑ 119534B 538a
🔝 45311B 276a		 ✅ ∑ -1741B -8a
🔝 +0B +0a (-1.44%)		 0.10%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client ∑ 121274B 546a
🔝 45311B 276a		 ∑ 119534B 538a
🔝 45311B 276a		 ✅ ∑ -1740B -8a
🔝 +0B +0a (-1.43%)		 0.10%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server ∑ 511041B 1011a
🔝 219032B 303a		 ∑ 503729B 998a
🔝 219032B 303a		 ✅ ∑ -7312B -13a
🔝 +0B +0a (-1.43%)		 0.87%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server ∑ 460084B 798a
🔝 215884B 296a		 ∑ 453884B 793a
🔝 216644B 302a		 ✅ ∑ -6200B -5a
🔝 +760B +6a (-1.35%)		 0.97%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server ∑ 470400B 762a
🔝 208072B 221a		 ∑ 464200B 757a
🔝 208072B 221a		 ✅ ∑ -6200B -5a
🔝 +0B +0a (-1.32%)		 0.95%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client ∑ 449329B 772a
🔝 183618B 230a		 ∑ 443557B 763a
🔝 184080B 199a		 ✅ ∑ -5772B -9a
🔝 +462B -31a (-1.28%)		 0.10%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client ∑ 457869B 751a
🔝 178267B 249a		 ∑ 452001B 742a
🔝 178331B 249a		 ✅ ∑ -5868B -9a
🔝 +64B +0a (-1.28%)		 0.10%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client ∑ 457901B 751a
🔝 178283B 249a		 ∑ 452033B 742a
🔝 178347B 249a		 ✅ ∑ -5868B -9a
🔝 +64B +0a (-1.28%)		 0.10%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client ∑ 451105B 777a
🔝 183946B 233a		 ∑ 445333B 768a
🔝 184234B 233a		 ✅ ∑ -5772B -9a
🔝 +288B +0a (-1.28%)		 0.10%
handshake_session_id_1.3_no_crypto_client ∑ 135853B 644a
🔝 49531B 191a		 ∑ 137389B 644a
🔝 51067B 191a		 ⚠️ ∑ +1536B +0a
🔝 +1536B +0a (1.13%)		 0.10%
handshake_tickets_1.3_no_crypto_client ∑ 136109B 644a
🔝 49531B 191a		 ∑ 137645B 644a
🔝 51067B 191a		 ⚠️ ∑ +1536B +0a
🔝 +1536B +0a (1.13%)		 0.10%
handshake_no_resume_1.3_no_crypto_client ∑ 109367B 521a
🔝 45311B 276a		 ∑ 110583B 521a
🔝 45311B 276a		 ⚠️ ∑ +1216B +0a
🔝 +0B +0a (1.11%)		 0.10%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client ∑ 530054B 981a
🔝 190240B 242a		 ∑ 524506B 972a
🔝 190528B 242a		 ✅ ∑ -5548B -9a
🔝 +288B +0a (-1.05%)		 0.10%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client ∑ 530118B 981a
🔝 190240B 242a		 ∑ 524570B 972a
🔝 190528B 242a		 ✅ ∑ -5548B -9a
🔝 +288B +0a (-1.05%)		 0.10%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client ∑ 530950B 981a
🔝 190576B 242a		 ∑ 525402B 972a
🔝 190864B 242a		 ✅ ∑ -5548B -9a
🔝 +288B +0a (-1.04%)		 0.10%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client ∑ 531014B 981a
🔝 190576B 242a		 ∑ 525466B 972a
🔝 190864B 242a		 ✅ ∑ -5548B -9a
🔝 +288B +0a (-1.04%)		 0.10%
handshake_session_id_1.2_no_crypto_client ∑ 130066B 580a
🔝 49531B 191a		 ∑ 131378B 580a
🔝 51067B 191a		 ⚠️ ∑ +1312B +0a
🔝 +1536B +0a (1.01%)		 0.10%
handshake_tickets_1.2_no_crypto_client ∑ 131738B 586a
🔝 49531B 191a		 ∑ 133050B 586a
🔝 51067B 191a		 ⚠️ ∑ +1312B +0a
🔝 +1536B +0a (1.00%)		 0.10%
handshake_no_resume_1.2_no_crypto_client ∑ 108528B 522a
🔝 45311B 276a		 ∑ 109584B 522a
🔝 45311B 276a		 ⚠️ ∑ +1056B +0a
🔝 +0B +0a (0.97%)		 0.10%
handshake_session_id_ring_1.3_ecdsap256_chacha_client ∑ 157229B 678a
🔝 49513B 191a		 ∑ 155808B 670a
🔝 51049B 191a		 ✅ ∑ -1421B -8a
🔝 +1536B +0a (-0.90%)		 0.10%
handshake_session_id_ring_1.3_ecdsap256_aes_client ∑ 157225B 678a
🔝 49513B 191a		 ∑ 155807B 670a
🔝 51049B 191a		 ✅ ∑ -1418B -8a
🔝 +1536B +0a (-0.90%)		 0.10%
handshake_session_id_ring_1.3_ecdsap384_aes_client ∑ 158660B 682a
🔝 49542B 191a		 ∑ 157240B 674a
🔝 51078B 191a		 ✅ ∑ -1420B -8a
🔝 +1536B +0a (-0.89%)		 0.10%
handshake_session_id_ring_1.3_ecdsap384_chacha_client ∑ 158659B 682a
🔝 49542B 191a		 ∑ 157241B 674a
🔝 51078B 191a		 ✅ ∑ -1418B -8a
🔝 +1536B +0a (-0.89%)		 0.10%
handshake_tickets_ring_1.3_ecdsap256_aes_client ∑ 159052B 680a
🔝 49513B 191a		 ∑ 157632B 672a
🔝 51049B 191a		 ✅ ∑ -1420B -8a
🔝 +1536B +0a (-0.89%)		 0.10%
handshake_tickets_ring_1.3_ecdsap256_chacha_client ∑ 159052B 680a
🔝 49513B 191a		 ∑ 157632B 672a
🔝 51049B 191a		 ✅ ∑ -1420B -8a
🔝 +1536B +0a (-0.89%)		 0.10%
handshake_tickets_ring_1.3_ecdsap384_aes_client ∑ 160483B 684a
🔝 49542B 191a		 ∑ 159063B 676a
🔝 51078B 191a		 ✅ ∑ -1420B -8a
🔝 +1536B +0a (-0.88%)		 0.10%
handshake_tickets_ring_1.3_ecdsap384_chacha_client ∑ 160483B 684a
🔝 49542B 191a		 ∑ 159063B 676a
🔝 51078B 191a		 ✅ ∑ -1420B -8a
🔝 +1536B +0a (-0.88%)		 0.10%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server ∑ 431963B 686a
🔝 189629B 205a		 ∑ 428747B 675a
🔝 189629B 205a		 ✅ ∑ -3216B -11a
🔝 +0B +0a (-0.74%)		 0.10%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server ∑ 432063B 687a
🔝 189629B 205a		 ∑ 428847B 676a
🔝 189629B 205a		 ✅ ∑ -3216B -11a
🔝 +0B +0a (-0.74%)		 0.10%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server ∑ 434211B 693a
🔝 189841B 205a		 ∑ 430991B 682a
🔝 189841B 205a		 ✅ ∑ -3220B -11a
🔝 +0B +0a (-0.74%)		 0.10%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server ∑ 434179B 693a
🔝 189841B 205a		 ∑ 430963B 682a
🔝 189841B 205a		 ✅ ∑ -3216B -11a
🔝 +0B +0a (-0.74%)		 0.10%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server ∑ 480954B 939a
🔝 208084B 238a		 ∑ 477638B 927a
🔝 208085B 238a		 ✅ ∑ -3316B -12a
🔝 +1B +0a (-0.69%)		 0.10%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server ∑ 478802B 933a
🔝 207419B 238a		 ∑ 475522B 921a
🔝 207421B 238a		 ✅ ∑ -3280B -12a
🔝 +2B +0a (-0.69%)		 0.10%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server ∑ 486986B 919a
🔝 205349B 207a		 ∑ 483702B 907a
🔝 205349B 207a		 ✅ ∑ -3284B -12a
🔝 +0B +0a (-0.67%)		 0.10%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server ∑ 478734B 933a
🔝 207404B 238a		 ∑ 475518B 922a
🔝 207404B 238a		 ✅ ∑ -3216B -11a
🔝 +0B +0a (-0.67%)		 0.10%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server ∑ 480878B 939a
🔝 208067B 238a		 ∑ 477662B 928a
🔝 208067B 238a		 ✅ ∑ -3216B -11a
🔝 +0B +0a (-0.67%)		 0.10%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server ∑ 487054B 919a
🔝 205349B 207a		 ∑ 483842B 908a
🔝 205349B 207a		 ✅ ∑ -3212B -11a
🔝 +0B +0a (-0.66%)		 0.10%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server ∑ 489206B 925a
🔝 205561B 207a		 ∑ 485986B 914a
🔝 205561B 207a		 ✅ ∑ -3220B -11a
🔝 +0B +0a (-0.66%)		 0.10%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server ∑ 489130B 925a
🔝 205561B 207a		 ∑ 485918B 914a
🔝 205561B 207a		 ✅ ∑ -3212B -11a
🔝 +0B +0a (-0.66%)		 0.10%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client ∑ 423914B 705a
🔝 174229B 219a		 ∑ 422114B 697a
🔝 174814B 197a		 ✅ ∑ -1800B -8a
🔝 +585B -22a (-0.42%)		 0.10%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client ∑ 422526B 701a
🔝 174200B 219a		 ∑ 420735B 693a
🔝 174785B 197a		 ✅ ∑ -1791B -8a
🔝 +585B -22a (-0.42%)		 0.10%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client ∑ 423882B 705a
🔝 174229B 219a		 ∑ 422091B 697a
🔝 174814B 197a		 ✅ ∑ -1791B -8a
🔝 +585B -22a (-0.42%)		 0.10%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client ∑ 422503B 701a
🔝 174200B 219a		 ∑ 420731B 694a
🔝 174785B 197a		 ✅ ∑ -1772B -7a
🔝 +585B -22a (-0.42%)		 0.10%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client ∑ 489690B 931a
🔝 188023B 242a		 ∑ 488219B 923a
🔝 188311B 242a		 ✅ ∑ -1471B -8a
🔝 +288B +0a (-0.30%)		 0.10%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client ∑ 491127B 934a
🔝 188076B 242a		 ∑ 489666B 927a
🔝 188364B 242a		 ✅ ∑ -1461B -7a
🔝 +288B +0a (-0.30%)		 0.10%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client ∑ 488794B 931a
🔝 187687B 242a		 ∑ 487351B 924a
🔝 187975B 242a		 ✅ ∑ -1443B -7a
🔝 +288B +0a (-0.30%)		 0.10%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client ∑ 491950B 934a
🔝 188412B 242a		 ∑ 490498B 927a
🔝 188700B 242a		 ✅ ∑ -1452B -7a
🔝 +288B +0a (-0.30%)		 0.10%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client ∑ 492042B 935a
🔝 188412B 242a		 ∑ 490599B 928a
🔝 188700B 242a		 ✅ ∑ -1443B -7a
🔝 +288B +0a (-0.29%)		 0.10%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client ∑ 488830B 930a
🔝 187687B 242a		 ∑ 487406B 924a
🔝 187975B 242a		 ✅ ∑ -1424B -6a
🔝 +288B +0a (-0.29%)		 0.10%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client ∑ 491054B 934a
🔝 188076B 242a		 ∑ 489630B 928a
🔝 188364B 242a		 ✅ ∑ -1424B -6a
🔝 +288B +0a (-0.29%)		 0.10%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client ∑ 489726B 930a
🔝 188023B 242a		 ∑ 488311B 924a
🔝 188311B 242a		 ✅ ∑ -1415B -6a
🔝 +288B +0a (-0.29%)		 0.10%

Additional information

Historical results

Checkout details:

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 23, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Oct 23, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 95.20295% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.64%. Comparing base (07af545) to head (8dbb061).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/client/config.rs 93.40% 6 Missing ⚠️
rustls/src/client/test.rs 40.00% 2 Missing and 1 partial ⚠️
rustls/src/lib.rs 50.00% 3 Missing ⚠️
rustls/src/client/tls13.rs 96.87% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2722      +/-   ##
==========================================
- Coverage   93.66%   93.64%   -0.02%     
==========================================
  Files         100      101       +1     
  Lines       22043    22108      +65     
  Branches      634      634              
==========================================
+ Hits        20646    20703      +57     
- Misses       1249     1257       +8     
  Partials      148      148

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctz

This comment was marked as resolved.

Sign in to view
This was referenced Oct 27, 2025
Merged
Merged
@ctz ctz force-pushed the jbp-client-storage-key branch 3 times, most recently from 42b3cfa to a1f4262 Compare October 30, 2025 08:59
@ctz ctz marked this pull request as ready for review October 30, 2025 08:59
djc
djc reviewed Oct 30, 2025
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty nice!

@ctz ctz force-pushed the jbp-client-storage-key branch 2 times, most recently from bf74743 to 0e4c751 Compare November 13, 2025 09:40
djc
djc reviewed Nov 13, 2025
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more suggestions.

@ctz ctz force-pushed the jbp-client-storage-key branch 3 times, most recently from ed11ed5 to 5d16b61 Compare November 14, 2025 14:49
djc
djc approved these changes Nov 18, 2025
View reviewed changes
@ctz
Remove log assertions in cross-domain resumption test
14f8140 
Eventually it becomes impossible to discern the two cases, so
this logging cannot be sustained.
@ctz ctz force-pushed the jbp-client-storage-key branch from 5d16b61 to 36a90b2 Compare November 27, 2025 16:02
@ctz ctz force-pushed the jbp-client-storage-key branch from 36a90b2 to 8dbb061 Compare November 27, 2025 17:32
@ctz ctz added this pull request to the merge queue Nov 27, 2025
Merged via the queue into main with commit 1f51a0d Nov 27, 2025
40 checks passed
@ctz ctz deleted the jbp-client-storage-key branch November 27, 2025 17:58
@ctz
Copy link
Member Author

ctz commented Dec 10, 2025

This should also address/ameliorate quinn-rs/quinn#2299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djc djc djc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ctz @djc