Skip to content

ML-DSA signing keys #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
djc merged 3 commits into from
Sep 23, 2025
Merged

ML-DSA signing keys #2579

djc merged 3 commits into from
Sep 23, 2025

Conversation

@djc
Copy link
Member

@djc djc commented Jul 26, 2025 •
edited
Loading

Fixes #2577.

Proposed release notes

  • Support using ML-DSA keys for signing when the aws-lc-rs-unstable feature is enabled.

@djc djc mentioned this pull request Jul 26, 2025
Merged
@rustls-benchmarking
Copy link

rustls-benchmarking bot commented Jul 26, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2510544 2486414 ✅ -24130 (-0.96%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 52947184 53236594 ⚠️ 289410 (0.55%) 0.51%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2781443 2769099 ✅ -12344 (-0.44%) 0.28%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 43902697 44046142 ⚠️ 143445 (0.33%) 0.31%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9220468 9149378 -71090 (-0.77%) 0.78%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 52665405 52858234 192829 (0.37%) 0.53%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 52981250 52833716 -147534 (-0.28%) 0.46%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 52886674 53031724 145050 (0.27%) 0.64%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 42543029 42639545 96516 (0.23%) 0.32%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 52721243 52623584 -97659 (-0.19%) 0.75%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 43901215 43827450 -73765 (-0.17%) 0.29%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 43852588 43924884 72296 (0.16%) 0.38%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 52877871 52792464 -85407 (-0.16%) 0.46%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10479724 10496622 16898 (0.16%) 1.40%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11179593 11163906 -15687 (-0.14%) 1.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 42513747 42463974 -49773 (-0.12%) 0.48%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 52701980 52762127 60147 (0.11%) 0.69%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 42640843 42596977 -43866 (-0.10%) 0.31%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 52774318 52724106 -50212 (-0.10%) 0.70%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 52916018 52867804 -48214 (-0.09%) 0.53%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 52903692 52951742 48050 (0.09%) 0.65%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 52605219 52652836 47617 (0.09%) 0.55%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 42512422 42542564 30142 (0.07%) 0.45%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3291102 3293284 2182 (0.07%) 0.25%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 42597839 42572653 -25186 (-0.06%) 0.49%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9138378 9143648 5270 (0.06%) 1.31%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 42464491 42488164 23673 (0.06%) 0.35%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 43895053 43871178 -23875 (-0.05%) 0.34%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 43852933 43875649 22716 (0.05%) 0.38%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3294446 3292816 -1630 (-0.05%) 0.24%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11137974 11142669 4695 (0.04%) 1.58%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3928704 3927189 -1515 (-0.04%) 0.33%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2761817 2762408 591 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3931319 3931877 558 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2483439 2483357 -82 (-0.00%) 0.86%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1574198 1574246 48 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1576448 1576492 44 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1281541 1281552 11 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7216493 7216464 -29 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 52974285 52974466 181 (0.00%) 0.74%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 43925741 43925889 148 (0.00%) 0.39%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1280374 1280377 3 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34735643 34735606 -37 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7214532 7214529 -3 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34733917 34733910 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46111150 46111141 -9 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 45998991 45998983 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58073637 58073629 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46001596 46001590 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46167488 46167482 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80347963 80347973 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80342021 80342014 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46009663 46009659 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58061951 58061946 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92599070 92599077 7 (0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_server 105021804 105021811 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58182286 58182283 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58182700 58182697 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46162178 46162176 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92588935 92588939 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92642862 92642858 -4 (-0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 117355108 117355103 -5 (-0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 117407325 117407330 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80233868 80233871 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80244548 80244546 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 45901595 45901596 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46170783 46170782 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58063495 58063494 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58113725 58113726 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58191247 58191248 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80350629 80350630 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92642447 92642448 1 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104969578 104969577 -1 (-0.00%) 0.20%
handshake_session_id_1.3_no_crypto_client 2200449 2200449 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57954707 57954707 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 3306488 3306488 0 (0.00%) 0.30%
handshake_no_resume_ring_1.3_rsa_aes_client 2327405 2327405 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11116355 11116355 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2333059 2333059 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 30485470 30485470 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30457557 30457557 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1715992 1715992 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92652682 92652682 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30362281 30362281 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 31656727 31656727 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 31964572 31964572 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4829371 4829371 0 (0.00%) 0.33%
handshake_tickets_ring_1.2_rsa_aes_client 3790318 3790318 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11110601 11110601 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 30564554 30564554 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31534537 31534537 0 (0.00%) 0.20%
handshake_tickets_1.3_no_crypto_server 2060754 2060754 0 (0.00%) 0.23%
handshake_tickets_ring_1.3_rsa_chacha_client 30492323 30492323 0 (0.00%) 0.20%
handshake_tickets_1.3_no_crypto_client 2217249 2217249 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 31656827 31656827 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 30557680 30557680 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31534517 31534517 0 (0.00%) 0.20%
handshake_tickets_1.2_no_crypto_server 1190748 1190748 0 (0.00%) 0.56%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30453931 30453931 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 31861726 31861726 0 (0.00%) 0.20%
handshake_no_resume_1.2_no_crypto_server 73498 73498 0 (0.00%) 0.23%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 31861724 31861724 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 31861612 31861612 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31534637 31534637 0 (0.00%) 0.20%
handshake_session_id_1.3_no_crypto_server 2095741 2095741 0 (0.00%) 0.23%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30450578 30450578 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30365907 30365907 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 30488177 30488177 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10955713 10955713 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2202942 2202942 0 (0.00%) 0.20%
handshake_no_resume_1.2_no_crypto_client 91676 91676 0 (0.00%) 0.20%
handshake_session_id_1.2_no_crypto_client 1125917 1125917 0 (0.00%) 0.36%
handshake_tickets_1.2_no_crypto_client 1211562 1211562 0 (0.00%) 0.50%
handshake_session_id_ring_1.3_ecdsap384_aes_server 31656707 31656707 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 3905336 3905336 0 (0.00%) 0.25%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92589314 92589314 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 30560408 30560408 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3818180 3818180 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 3401386 3401386 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 31964684 31964684 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3725999 3725999 0 (0.00%) 0.26%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80238399 80238399 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 31964686 31964686 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30358928 30358928 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4208320 4208320 0 (0.00%) 0.20%
handshake_no_resume_1.3_no_crypto_server 100156 100156 0 (0.00%) 0.20%
handshake_session_id_1.2_no_crypto_server 1023998 1023998 0 (0.00%) 0.67%
handshake_no_resume_1.3_no_crypto_client 101439 101439 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.06 ms 0.00 ms (0.31%) 6.82%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.59 ms 1.60 ms 0.00 ms (0.27%) 4.51%
handshake_session_id_ring_1.2_rsa_aes 1.40 ms 1.41 ms 0.00 ms (0.24%) 1.27%
handshake_no_resume_1.2_no_crypto 74.42 µs 74.25 µs -0.17 µs (-0.22%) 7.05%
handshake_no_resume_1.3_no_crypto 81.74 µs 81.56 µs -0.18 µs (-0.22%) 6.58%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 7.89 ms 7.90 ms 0.02 ms (0.21%) 1.40%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 536.22 µs 535.11 µs -1.11 µs (-0.21%) 2.13%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 7.23 ms 7.24 ms 0.01 ms (0.19%) 1.35%
handshake_no_resume_ring_1.3_ecdsap256_aes 456.89 µs 456.05 µs -0.84 µs (-0.18%) 2.14%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 7.41 ms 7.43 ms 0.01 ms (0.18%) 1.37%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 4.96 ms 4.97 ms 0.01 ms (0.17%) 3.49%
handshake_session_id_1.3_no_crypto 646.03 µs 644.97 µs -1.06 µs (-0.16%) 5.45%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 8.08 ms 8.10 ms 0.01 ms (0.16%) 1.41%
handshake_session_id_ring_1.3_ecdsap256_aes 5.39 ms 5.40 ms 0.01 ms (0.16%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 8.08 ms 8.09 ms 0.01 ms (0.15%) 1.56%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 7.25 ms 7.26 ms 0.01 ms (0.15%) 1.63%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 7.91 ms 7.92 ms 0.01 ms (0.15%) 1.25%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.48 ms 4.48 ms 0.01 ms (0.15%) 3.50%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 7.93 ms 7.94 ms 0.01 ms (0.14%) 1.57%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.14 ms 5.14 ms 0.01 ms (0.14%) 3.37%
handshake_tickets_ring_1.3_ecdsap256_aes 5.44 ms 5.45 ms 0.01 ms (0.14%) 1.00%
transfer_no_resume_ring_1.2_rsa_aes 5.70 ms 5.71 ms 0.01 ms (0.14%) 2.33%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.75 ms 1.75 ms 0.00 ms (0.14%) 4.93%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 8.10 ms 8.11 ms 0.01 ms (0.14%) 1.29%
handshake_session_id_ring_1.3_rsa_aes 5.88 ms 5.89 ms 0.01 ms (0.13%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 8.09 ms 8.10 ms 0.01 ms (0.13%) 1.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 7.92 ms 7.93 ms 0.01 ms (0.12%) 1.60%
handshake_tickets_1.3_no_crypto 619.84 µs 619.09 µs -0.74 µs (-0.12%) 4.86%
handshake_tickets_ring_1.3_rsa_aes 5.94 ms 5.94 ms 0.01 ms (0.11%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.54 ms 8.55 ms 0.01 ms (0.11%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 533.25 µs 532.73 µs -0.52 µs (-0.10%) 2.31%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.37 ms 5.37 ms 0.01 ms (0.10%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.42 ms 5.42 ms 0.00 ms (0.09%) 1.00%
transfer_no_resume_1.2_no_crypto 11.65 ms 11.66 ms 0.01 ms (0.09%) 1.40%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.17 ms 5.17 ms 0.00 ms (0.09%) 2.82%
handshake_no_resume_ring_1.2_rsa_aes 936.50 µs 937.30 µs 0.80 µs (0.09%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 7.41 ms 7.41 ms 0.01 ms (0.08%) 1.25%
handshake_session_id_1.2_no_crypto 339.97 µs 339.71 µs -0.26 µs (-0.08%) 5.98%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.46 ms 8.47 ms 0.01 ms (0.07%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.22 ms 1.23 ms 0.00 ms (0.07%) 1.10%
handshake_tickets_ring_1.2_rsa_aes 1.49 ms 1.49 ms 0.00 ms (0.07%) 1.56%
handshake_no_resume_ring_1.3_rsa_chacha 945.62 µs 944.95 µs -0.67 µs (-0.07%) 1.00%
transfer_no_resume_ring_1.3_rsa_chacha 13.34 ms 13.35 ms 0.01 ms (0.07%) 1.00%
transfer_no_resume_ring_1.3_rsa_aes 5.77 ms 5.78 ms 0.00 ms (0.06%) 2.46%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.39 ms 8.39 ms 0.00 ms (0.05%) 1.71%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.19 ms 1.19 ms -0.00 ms (-0.05%) 5.70%
handshake_session_id_ring_1.3_rsa_chacha 5.86 ms 5.86 ms 0.00 ms (0.05%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 944.03 µs 943.59 µs -0.44 µs (-0.05%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.48 ms 8.49 ms 0.00 ms (0.04%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.22 ms 1.22 ms -0.00 ms (-0.04%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.55 ms 3.55 ms 0.00 ms (0.04%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 5.91 ms 5.91 ms 0.00 ms (0.04%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.51 ms 8.52 ms 0.00 ms (0.04%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.88 ms 13.89 ms 0.00 ms (0.04%) 1.24%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.18 ms 1.18 ms -0.00 ms (-0.03%) 6.75%
handshake_tickets_1.2_no_crypto 375.14 µs 375.03 µs -0.10 µs (-0.03%) 5.19%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.55 ms 3.55 ms -0.00 ms (-0.02%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.19 ms 13.19 ms -0.00 ms (-0.02%) 1.30%
transfer_no_resume_ring_1.3_ecdsap384_chacha 15.95 ms 15.95 ms -0.00 ms (-0.01%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_chacha 452.89 µs 452.92 µs 0.04 µs (0.01%) 1.85%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.29 ms 5.29 ms 0.00 ms (0.01%) 2.47%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.86 ms 13.86 ms 0.00 ms (0.01%) 1.53%
transfer_no_resume_1.3_no_crypto 11.71 ms 11.71 ms 0.00 ms (0.01%) 1.35%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.85 ms 12.85 ms -0.00 ms (-0.00%) 1.00%

Additional information

Historical results

Checkout details:

@djc djc mentioned this pull request Jul 26, 2025
Closed
1 task
ctz
ctz approved these changes Aug 5, 2025
View reviewed changes
cpu
cpu reviewed Aug 20, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I got this branch building locally to fiddle with review feedback using this small patch: 7ae2f2b

What kind of test coverage did you have in-mind for this to be ready to go? There's some low-level ML-DSA test vectors recently added to Wycheproof (C2SP/wycheproof#146) but I'm not sure how well they'll map into this context.

@djc
Copy link
Member Author

djc commented Aug 20, 2025

I was thinking we could do a handshake with a freshly generated key? I guess that would require rcgen support maybe.

This was referenced Sep 15, 2025
Closed
Merged
@codecov
Copy link

codecov bot commented Sep 19, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.81%. Comparing base (5d7e5fb) to head (e46bb95).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2579   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files          96       96           
  Lines       21826    21826           
  Branches      614      614           
=======================================
  Hits        20695    20695           
  Misses       1003     1003           
  Partials      128      128

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was referenced Sep 19, 2025
Merged
Closed
@djc djc force-pushed the ml-dsa-signing branch 2 times, most recently from 742dadc to 1b1ce27 Compare September 22, 2025 13:15
cpu
cpu approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :-)

@djc djc force-pushed the ml-dsa-signing branch 2 times, most recently from 966b6fd to 40bb6a4 Compare September 23, 2025 07:15
ctz
ctz reviewed Sep 23, 2025
View reviewed changes
ctz
ctz approved these changes Sep 23, 2025
View reviewed changes
@djc djc enabled auto-merge September 23, 2025 14:57
@djc djc added this pull request to the merge queue Sep 23, 2025
Merged via the queue into main with commit 9198bbd Sep 23, 2025
40 checks passed
@djc djc deleted the ml-dsa-signing branch September 23, 2025 15:18
@djc
Copy link
Member Author

djc commented Sep 23, 2025

  • Published rustls-post-quantum v0.2.4 at registry crates-io
  • [new tag] rustls-post-quantum-v/0.2.4 -> rustls-post-quantum-v/0.2.4
  • Release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't seem to load ML-DSA private key with rustls-post-quantum 0.2.3

4 participants

@djc @cpu @ctz