Skip to content

0.23.30 release prep & 2575 backport #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cpu merged 2 commits into from
Jul 27, 2025
Merged

0.23.30 release prep & 2575 backport #2576

cpu merged 2 commits into from
Jul 27, 2025

Conversation

@cpu
Copy link
Member

@cpu cpu commented Jul 26, 2025 •
edited
Loading

This is a backport of #2575 to rel-0.23 to prepare a 0.23.30 release with the fix.

Proposed release notes

  • Fixes a bug with the unbuffered connection API that could result in deframing junk data after a close notify alert was received.
  • Updates Connection::complete_io() to yield a WouldBlock error when both read/write operations are blocked.

@cpu cpu mentioned this pull request Jul 26, 2025
Merged
@codecov
Copy link

codecov bot commented Jul 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.25%. Comparing base (8b8ba56) to head (42f18ec).

Additional details and impacted files 
@@            Coverage Diff            @@
##           rel-0.23    #2576   +/-   ##
=========================================
  Coverage     95.25%   95.25%           
=========================================
  Files            97       97           
  Lines         21767    21771    +4     
=========================================
+ Hits          20734    20738    +4     
  Misses         1033     1033

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cpu cpu force-pushed the ci/cpu-backport-2575-rel-0.23 branch from 42f18ec to 5435be3 Compare July 26, 2025 13:26
ctz
ctz approved these changes Jul 26, 2025
View reviewed changes
Copy link
Member

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also #2578

@rustls-benchmarking
Copy link

rustls-benchmarking bot commented Jul 26, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3124528 3175272 ⚠️ 50744 (1.62%) 0.20%
handshake_session_id_1.3_no_crypto_client 2225072 2204252 ✅ -20820 (-0.94%) 0.53%
handshake_tickets_1.3_no_crypto_client 2243618 2222798 ✅ -20820 (-0.93%) 0.21%
handshake_session_id_1.2_no_crypto_client 1162312 1154182 ✅ -8130 (-0.70%) 0.29%
handshake_tickets_1.2_no_crypto_client 1250624 1242494 ✅ -8130 (-0.65%) 0.24%
handshake_session_id_1.2_no_crypto_server 1046631 1052271 ⚠️ 5640 (0.54%) 0.54%
handshake_tickets_1.2_no_crypto_server 1206551 1212551 ⚠️ 6000 (0.50%) 0.46%
handshake_no_resume_1.2_no_crypto_server 74693 74891 ⚠️ 198 (0.27%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3842357 3833507 ✅ -8850 (-0.23%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4175311 4166461 ✅ -8850 (-0.21%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4249476 4240536 ✅ -8940 (-0.21%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 63987464 63624337 -363127 (-0.57%) 0.81%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 63625058 63337214 -287844 (-0.45%) 1.01%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 49286972 49120492 -166480 (-0.34%) 0.53%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 63659265 63850660 191395 (0.30%) 0.69%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 47892006 47750131 -141875 (-0.30%) 0.62%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11359838 11333171 -26667 (-0.23%) 1.13%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 49148645 49259465 110820 (0.23%) 0.45%
handshake_tickets_ring_1.2_rsa_aes_client 4503431 4494491 -8940 (-0.20%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 63729158 63620094 -109064 (-0.17%) 0.79%
handshake_session_id_ring_1.2_rsa_aes_server 4159090 4165940 6850 (0.16%) 0.29%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 63389213 63491767 102554 (0.16%) 0.50%
handshake_tickets_ring_1.2_rsa_aes_server 4612894 4620104 7210 (0.16%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3752061 3757521 5460 (0.15%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9521823 9508330 -13493 (-0.14%) 0.89%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10426217 10440893 14676 (0.14%) 0.59%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 47770005 47835900 65895 (0.14%) 0.28%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3303490 3307776 4286 (0.13%) 0.24%
handshake_no_resume_1.3_no_crypto_client 112443 112305 -138 (-0.12%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4885858 4891678 5820 (0.12%) 0.27%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 63706342 63637972 -68370 (-0.11%) 0.80%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 63563233 63497115 -66118 (-0.10%) 0.46%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4297545 4293175 -4370 (-0.10%) 2.12%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 63491050 63432019 -59031 (-0.09%) 0.82%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 49155972 49116529 -39443 (-0.08%) 0.53%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 49147343 49184608 37265 (0.08%) 0.31%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 63672954 63717606 44652 (0.07%) 0.50%
handshake_no_resume_1.3_no_crypto_server 98263 98330 67 (0.07%) 0.26%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 47828208 47855535 27327 (0.06%) 0.53%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30317841 30302297 -15544 (-0.05%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30320605 30305065 -15540 (-0.05%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30324697 30309157 -15540 (-0.05%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30409491 30393947 -15544 (-0.05%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30412255 30396715 -15540 (-0.05%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30416347 30400807 -15540 (-0.05%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 30574688 30559134 -15554 (-0.05%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 30578770 30563216 -15554 (-0.05%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 30571415 30555871 -15544 (-0.05%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 30646319 30630765 -15554 (-0.05%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 30650401 30634847 -15554 (-0.05%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 30643025 30627481 -15544 (-0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4294393 4292391 -2002 (-0.05%) 2.18%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9506420 9510747 4327 (0.05%) 1.04%
handshake_no_resume_1.2_no_crypto_client 98750 98791 41 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 63498734 63524487 25753 (0.04%) 0.85%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 49174179 49155015 -19164 (-0.04%) 0.53%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 47897140 47878508 -18632 (-0.04%) 0.26%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 63506345 63484486 -21859 (-0.03%) 0.79%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 47872900 47857944 -14956 (-0.03%) 0.55%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1757967 1758490 523 (0.03%) 1.39%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1755396 1755863 467 (0.03%) 1.50%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 63689300 63672854 -16446 (-0.03%) 0.65%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11339243 11342039 2796 (0.02%) 1.07%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3131240 3131904 664 (0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 31967312 31973762 6450 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 31970057 31976507 6450 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 31970078 31976528 6450 (0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32069552 32076002 6450 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32072297 32078747 6450 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32072318 32078768 6450 (0.02%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 45915924 45924884 8960 (0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46017298 46026264 8966 (0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46010419 46019381 8962 (0.02%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46009151 46018109 8958 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46122480 46131437 8957 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46172698 46181663 8965 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46185608 46194573 8965 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46174668 46183627 8959 (0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1286312 1286557 245 (0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1285130 1285373 243 (0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31509943 31515853 5910 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31512722 31518632 5910 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31513014 31518924 5910 (0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 31631923 31637833 5910 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 31634702 31640612 5910 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 31634994 31640904 5910 (0.02%) 0.20%
handshake_session_id_1.3_no_crypto_server 2109290 2108990 -300 (-0.01%) 0.44%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 49127548 49134266 6718 (0.01%) 0.45%
handshake_tickets_1.3_no_crypto_server 2072783 2073023 240 (0.01%) 0.34%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80247215 80256182 8967 (0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80244036 80252998 8962 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80252186 80261143 8957 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80352544 80361503 8959 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80355146 80364105 8959 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80366096 80375045 8949 (0.01%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104983673 104992637 8964 (0.01%) 0.20%
transfer_no_resume_1.3_no_crypto_server 105029323 105038283 8960 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 47877208 47880833 3625 (0.01%) 0.52%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2661114 2660965 -149 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2664682 2664577 -105 (-0.00%) 0.85%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7210747 7211001 254 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7208797 7209040 243 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2243361 2243427 66 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 57996198 57997477 1279 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11114429 11114674 245 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58007823 58009101 1278 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58004906 58006183 1277 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11108668 11108911 243 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3306439 3306371 -68 (-0.00%) 0.27%
handshake_no_resume_ring_1.2_rsa_aes_server 10987629 10987818 189 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92532266 92533552 1286 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92522272 92523555 1283 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92533908 92535190 1282 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58112836 58113484 648 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58122853 58123496 643 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58122836 58123478 642 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92582999 92583642 643 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92584292 92584932 640 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92573005 92573635 630 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2333630 2333642 12 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339284 2339296 12 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717733 1717741 8 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34738524 34738545 21 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34736825 34736833 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58058621 58058624 3 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 117294552 117294555 3 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57902596 57902596 0 (0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 117342452 117342452 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_1.2_no_crypto 342.62 µs 347.09 µs 4.47 µs (1.31%) 3.65%
handshake_session_id_1.3_no_crypto 652.32 µs 659.04 µs 6.72 µs (1.03%) 2.72%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.07 ms 1.06 ms -0.01 ms (-1.02%) 2.80%
handshake_tickets_1.2_no_crypto 378.97 µs 382.72 µs 3.75 µs (0.99%) 3.50%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.24 ms 1.23 ms -0.01 ms (-0.76%) 2.70%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.24 ms 1.23 ms -0.01 ms (-0.66%) 2.26%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.09 ms 5.06 ms -0.03 ms (-0.57%) 3.97%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.30 ms 5.27 ms -0.03 ms (-0.57%) 4.36%
handshake_session_id_ring_1.2_rsa_aes 1.47 ms 1.47 ms 0.01 ms (0.53%) 1.24%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.74 ms 1.75 ms 0.01 ms (0.41%) 2.43%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 9.30 ms 9.26 ms -0.04 ms (-0.39%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.58 ms 1.59 ms 0.01 ms (0.36%) 2.48%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.27 ms 1.27 ms -0.00 ms (-0.33%) 1.07%
handshake_tickets_1.3_no_crypto 628.94 µs 630.85 µs 1.91 µs (0.30%) 3.98%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.33 ms 5.32 ms -0.02 ms (-0.30%) 3.49%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 9.12 ms 9.09 ms -0.02 ms (-0.27%) 1.02%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 9.30 ms 9.27 ms -0.02 ms (-0.26%) 1.14%
transfer_no_resume_ring_1.2_rsa_aes 5.83 ms 5.81 ms -0.01 ms (-0.25%) 2.80%
handshake_no_resume_ring_1.3_ecdsap256_aes 463.46 µs 462.37 µs -1.09 µs (-0.24%) 2.32%
transfer_no_resume_ring_1.3_rsa_aes 5.90 ms 5.88 ms -0.01 ms (-0.23%) 3.16%
handshake_tickets_ring_1.2_rsa_aes 1.54 ms 1.55 ms 0.00 ms (0.22%) 1.76%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 587.16 µs 585.90 µs -1.26 µs (-0.22%) 2.49%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 8.61 ms 8.59 ms -0.02 ms (-0.21%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 9.31 ms 9.29 ms -0.02 ms (-0.21%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 5.90 ms 5.91 ms 0.01 ms (0.21%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.65 ms 4.64 ms -0.01 ms (-0.20%) 3.87%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.78 ms 13.75 ms -0.03 ms (-0.20%) 1.45%
handshake_no_resume_ring_1.3_rsa_chacha 951.88 µs 950.18 µs -1.70 µs (-0.18%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 584.90 µs 583.87 µs -1.04 µs (-0.18%) 2.32%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 9.15 ms 9.13 ms -0.02 ms (-0.17%) 1.00%
transfer_no_resume_1.2_no_crypto 11.77 ms 11.76 ms -0.02 ms (-0.14%) 1.47%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 9.33 ms 9.32 ms -0.01 ms (-0.13%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 9.10 ms 9.09 ms -0.01 ms (-0.13%) 1.00%
handshake_no_resume_1.3_no_crypto 87.78 µs 87.89 µs 0.11 µs (0.12%) 8.29%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 8.43 ms 8.42 ms -0.01 ms (-0.12%) 1.00%
transfer_no_resume_ring_1.3_rsa_chacha 13.46 ms 13.44 ms -0.02 ms (-0.11%) 1.35%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 8.47 ms 8.46 ms -0.01 ms (-0.11%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 5.93 ms 5.92 ms -0.01 ms (-0.11%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.40 ms 5.41 ms 0.01 ms (0.10%) 2.94%
handshake_no_resume_ring_1.3_ecdsap256_chacha 459.50 µs 459.04 µs -0.46 µs (-0.10%) 2.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.26 ms 1.26 ms -0.00 ms (-0.10%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.47 ms 5.46 ms -0.00 ms (-0.09%) 1.00%
transfer_no_resume_1.3_no_crypto 11.82 ms 11.83 ms 0.01 ms (0.09%) 1.45%
handshake_no_resume_ring_1.3_rsa_aes 950.94 µs 950.12 µs -0.82 µs (-0.09%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 8.64 ms 8.64 ms -0.01 ms (-0.07%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.41 ms 5.41 ms 0.00 ms (0.07%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.56 ms 3.55 ms -0.00 ms (-0.07%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 943.97 µs 943.36 µs -0.61 µs (-0.06%) 1.04%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.12 ms 13.11 ms -0.01 ms (-0.06%) 1.36%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.80 ms 13.80 ms -0.01 ms (-0.06%) 1.42%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.46 ms 8.47 ms 0.00 ms (0.05%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 9.15 ms 9.14 ms -0.00 ms (-0.04%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.43 ms 5.43 ms -0.00 ms (-0.04%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.50 ms 8.49 ms -0.00 ms (-0.03%) 2.03%
handshake_tickets_ring_1.3_rsa_aes 5.96 ms 5.96 ms -0.00 ms (-0.03%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.56 ms 8.56 ms -0.00 ms (-0.02%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.49 ms 8.50 ms 0.00 ms (0.02%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.55 ms 3.55 ms 0.00 ms (0.02%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 5.87 ms 5.87 ms 0.00 ms (0.02%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.06 ms 16.06 ms 0.00 ms (0.01%) 1.17%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.97 ms 12.97 ms 0.00 ms (0.01%) 1.24%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.38 ms 5.38 ms -0.00 ms (-0.01%) 1.00%
handshake_no_resume_1.2_no_crypto 78.44 µs 78.43 µs -0.00 µs (-0.01%) 8.22%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.52 ms 8.52 ms -0.00 ms (-0.00%) 1.00%

Additional information

Historical results

Checkout details:

@cpu
Copy link
Member Author

cpu commented Jul 26, 2025

See also #2578

I updated the PR desc release notes to cover this backport as well assuming we'll merge it first. Suggested tweaks to the release notes addition welcome!

@djc djc mentioned this pull request Jul 26, 2025
Merged
@djc
Copy link
Member

djc commented Jul 26, 2025

See also #2580. I think it probably doesn't mention calling out in the release notes?

schreter and others added 2 commits July 26, 2025 17:54
@schreter @cpu
Fix: Do not try to call deframer on junk data
653bb3f 
After receiving close notify, the TLS stream ends. The receive buffer
can contain additional junk data received past close notify record,
which obviously cannot be interpreted anymore.

However, `UnbufferedConnectionCommon::process_tls_records_common()`
tried to interpret this junk data.

Add a check for `has_received_close_notify` to prevent calling the
deframer on junk data. Also update the test to test also with a longer
junk data (original junk data didn't trigger the bug).
@cpu
Cargo: rustls version 0.23.29 -> 0.23.30
786c1da
@cpu cpu force-pushed the ci/cpu-backport-2575-rel-0.23 branch from 5435be3 to 786c1da Compare July 26, 2025 21:54
@cpu
Copy link
Member Author

cpu commented Jul 26, 2025

I think this is ready for merge & release if everyone is happy with the proposed release notes.

@cpu cpu added this pull request to the merge queue Jul 27, 2025
Merged via the queue into rustls:rel-0.23 with commit 0ccbc63 Jul 27, 2025
32 checks passed
@cpu cpu deleted the ci/cpu-backport-2575-rel-0.23 branch July 27, 2025 13:03
@cpu
Copy link
Member Author

cpu commented Jul 27, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djc djc djc approved these changes

@ctz ctz ctz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cpu @djc @ctz @schreter