CI: deny all Clippy warnings including clippy::incompatible_msrv#2310
Merged
Conversation
cpu
approved these changes
Jan 22, 2025
cpu
left a comment
Member
There was a problem hiding this comment.
If clippy/CI are happy with this change, so am I. Thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2310 +/- ##
=======================================
Coverage 94.82% 94.82%
=======================================
Files 104 104
Lines 24100 24100
=======================================
Hits 22853 22853
Misses 1247 1247 ☔ View full report in Codecov by Sentry. |
1 task
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
djc
approved these changes
Jan 23, 2025
ctz
approved these changes
Jan 23, 2025
ctz
left a comment
Member
There was a problem hiding this comment.
Neat, I guess the reason for this has gone away -- though I don't think clippy has addressed the underlying false positive. But we can put this back if it is ever needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks to me like there is no need to ignore
clippy::incompatible_msrvin Clippy CI task to succeed with--deny warnings.Context comes from this comment: #2285 (comment)
For PR #2285 I would like to update CI to allow a single warning in most crates & deny all other warnings. I have already tried this with XXX TODO comments; PR #2285 still has green status with these updates.
Considering that ignoring
clippy::incompatible_msrvis not what we want for PR #2285, and that CI can succeed without ignoring this warning, I think we should remove this allow option as proposed here. I would also like to keep this update separate from PR #2285.