Skip to content

Remove remaining uses of docopt #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
djc merged 3 commits into from
Sep 24, 2024
Merged

Remove remaining uses of docopt #2132

djc merged 3 commits into from
Sep 24, 2024

Conversation

@ctz
Copy link
Member

@ctz ctz commented Sep 24, 2024

No description provided.

@ctz
Copy link
Member Author

ctz commented Sep 24, 2024

daily-tests run: https://github.com/rustls/rustls/actions/runs/11015347800/job/30588190069

@rustls-benchmarking
Copy link

rustls-benchmarking bot commented Sep 24, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10847392 10807948 -39444 (-0.36%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10826764 10800754 -26010 (-0.24%) 1.01%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8580103 8597740 17637 (0.21%) 1.24%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10464671 10446396 -18275 (-0.17%) 0.71%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8576730 8588071 11341 (0.13%) 0.98%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3094933 3097716 2783 (0.09%) 0.21%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3635329 3633063 -2266 (-0.06%) 0.45%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3095049 3094783 -266 (-0.01%) 0.25%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1284856 1284964 108 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3634026 3633760 -266 (-0.01%) 0.41%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1282509 1282588 79 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58252970 58256076 3106 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2169019 2169112 93 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2172135 2172061 -74 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46441640 46440359 -1281 (-0.00%) 0.39%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46485259 46486537 1278 (0.00%) 0.23%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1668638 1668610 -28 (-0.00%) 0.83%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32057909 32058393 484 (0.00%) 0.72%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717596 1717574 -22 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30344954 30344611 -343 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30747469 30747702 233 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30323376 30323150 -226 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30359240 30359435 195 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30781610 30781775 165 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30724769 30724642 -127 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32060943 32061062 119 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32061061 32061174 113 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30344671 30344776 105 (0.00%) 0.54%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32110838 32110948 110 (0.00%) 0.54%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34124146 34124228 82 (0.00%) 0.60%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32114180 32114103 -77 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34120986 34121066 80 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34118198 34118276 78 (0.00%) 0.43%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34121169 34121094 -75 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30724953 30725018 65 (0.00%) 0.40%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7612459 7612472 13 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30758839 30758882 43 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30759190 30759159 -31 (-0.00%) 0.57%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35185078 35185110 32 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30308727 30308752 25 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30308715 30308732 17 (0.00%) 0.44%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34127033 34127019 -14 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32113921 32113932 11 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34127111 34127122 11 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46476801 46476812 11 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46462879 46462869 -10 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 5834033 58340327 -10 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46492893 46492900 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58252761 58252769 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80561366 80561377 11 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80546363 80546356 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46477884 46477880 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92672488 92672495 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92665997 92666001 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92714406 92714402 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46488073 46488075 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80544648 80544651 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80644638 80644635 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92666740 92666743 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68671580 68671582 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80668291 80668293 2 (0.00%) 0.25%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80669828 80669830 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92715489 92715487 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58243336 58243335 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58331911 58331910 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92704784 92704785 1 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41794493 41794493 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42242696 42242696 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4679097 4679097 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43853649 43853649 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3907851 3907851 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43290370 43290370 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1667234 1667234 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43182653 43182653 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563606 2563606 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4999114 4999114 0 (0.00%) 4.38%
handshake_session_id_ring_1.3_rsa_chacha_server 43179820 43179820 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7614615 7614615 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42168986 42168986 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46396515 46396515 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42168480 42168480 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2663086 2663086 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41720042 41720042 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43293333 43293333 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41706324 41706324 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43950346 43950346 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42256642 42256642 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43293203 43293203 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58223755 58223755 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42182848 42182848 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4270372 4270372 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11291853 11291853 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58334586 58334586 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43856836 43856836 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43856989 43856989 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1933719 1933719 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42242274 42242274 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4535361 4535361 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11482583 11482583 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1926998 1926998 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43947159 43947159 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41705783 41705783 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43182783 43182783 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41795034 41795034 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4239160 4239160 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11476628 11476628 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4254329 4254329 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35187001 35187001 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2657243 2657243 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43950499 43950499 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3879393 3879393 0 (0.00%) 3.47%
handshake_session_id_ring_1.3_rsa_aes_client 41808752 41808752 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.52 ms 4.43 ms -0.08 ms (-1.78%) 4.99%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.24 ms 5.15 ms -0.08 ms (-1.56%) 4.61%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.46 ms 5.38 ms -0.08 ms (-1.53%) 5.38%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.47 ms 5.40 ms -0.08 ms (-1.42%) 5.25%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.36 ms 6.29 ms -0.07 ms (-1.18%) 4.15%
transfer_no_resume_ring_1.3_rsa_aes 6.85 ms 6.78 ms -0.08 ms (-1.12%) 3.75%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 458.48 µs 453.57 µs -4.91 µs (-1.07%) 2.75%
transfer_no_resume_ring_1.2_rsa_aes 6.77 ms 6.70 ms -0.07 ms (-1.06%) 3.34%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 456.66 µs 452.16 µs -4.50 µs (-0.99%) 3.42%
handshake_no_resume_ring_1.3_ecdsap256_chacha 500.86 µs 496.32 µs -4.54 µs (-0.91%) 2.60%
handshake_no_resume_ring_1.3_ecdsap256_aes 503.99 µs 499.43 µs -4.56 µs (-0.90%) 2.74%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.07 ms 2.06 ms -0.02 ms (-0.79%) 1.71%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.46 ms 9.40 ms -0.06 ms (-0.66%) 2.70%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.98 ms 12.90 ms -0.08 ms (-0.62%) 1.83%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.92 ms 13.84 ms -0.08 ms (-0.59%) 1.96%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.38 ms 1.37 ms -0.01 ms (-0.58%) 2.97%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.01 ms 12.93 ms -0.07 ms (-0.57%) 1.84%
transfer_no_resume_ring_1.3_rsa_chacha 13.49 ms 13.42 ms -0.07 ms (-0.54%) 1.91%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.70 ms 13.63 ms -0.07 ms (-0.53%) 1.89%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.51 ms -0.01 ms (-0.52%) 1.71%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.90 ms 1.89 ms -0.01 ms (-0.52%) 2.43%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.10 ms 16.03 ms -0.07 ms (-0.46%) 1.78%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.35 ms 1.35 ms -0.01 ms (-0.46%) 2.24%
handshake_no_resume_ring_1.3_rsa_chacha 984.79 µs 980.38 µs -4.40 µs (-0.45%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 984.37 µs 980.52 µs -3.85 µs (-0.39%) 1.08%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.17 ms 1.17 ms -0.00 ms (-0.34%) 1.32%
handshake_no_resume_ring_1.2_rsa_aes 978.01 µs 974.76 µs -3.24 µs (-0.33%) 1.25%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.39 ms 1.38 ms -0.00 ms (-0.33%) 2.10%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.17 ms 1.17 ms -0.00 ms (-0.31%) 1.64%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.59 ms -0.00 ms (-0.28%) 1.43%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.90 ms 4.92 ms 0.01 ms (0.27%) 2.22%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.56 ms 4.57 ms 0.01 ms (0.22%) 2.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.61 ms 5.62 ms 0.01 ms (0.21%) 1.71%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.27 ms 5.28 ms 0.01 ms (0.20%) 1.77%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.58 ms 4.59 ms 0.01 ms (0.19%) 2.12%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.85 ms 5.86 ms 0.01 ms (0.16%) 1.71%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms -0.01 ms (-0.15%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.30 ms 5.30 ms 0.01 ms (0.14%) 1.87%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms -0.00 ms (-0.12%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.62 ms 5.62 ms 0.01 ms (0.10%) 1.87%
handshake_session_id_ring_1.3_rsa_aes 7.04 ms 7.04 ms -0.01 ms (-0.10%) 1.40%
handshake_session_id_ring_1.3_rsa_chacha 7.00 ms 6.99 ms -0.01 ms (-0.08%) 1.37%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.60 ms 9.59 ms -0.01 ms (-0.08%) 1.07%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.51 ms 5.51 ms 0.00 ms (0.08%) 1.95%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.62 ms 6.62 ms -0.01 ms (-0.08%) 1.32%
handshake_session_id_ring_1.3_ecdsap256_aes 6.55 ms 6.55 ms -0.00 ms (-0.06%) 1.70%
handshake_tickets_ring_1.3_ecdsap384_aes 9.76 ms 9.76 ms -0.01 ms (-0.05%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 7.16 ms 7.15 ms -0.00 ms (-0.05%) 1.31%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.90 ms 4.90 ms 0.00 ms (0.04%) 1.79%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.71 ms 9.71 ms -0.00 ms (-0.04%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.64 ms 9.64 ms -0.00 ms (-0.04%) 1.13%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.51 ms 6.51 ms -0.00 ms (-0.04%) 1.62%
handshake_tickets_ring_1.3_ecdsap256_aes 6.67 ms 6.67 ms -0.00 ms (-0.04%) 1.34%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.53 ms 5.53 ms -0.00 ms (-0.02%) 1.80%
handshake_tickets_ring_1.3_rsa_chacha 7.10 ms 7.10 ms 0.00 ms (0.01%) 1.30%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.85 ms 5.85 ms 0.00 ms (0.01%) 1.96%

Additional information

Historical results

Checkout details:

@codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.63%. Comparing base (e16c197) to head (276b2b5).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2132   +/-   ##
=======================================
  Coverage   94.63%   94.63%           
=======================================
  Files         102      102           
  Lines       23412    23412           
=======================================
  Hits        22157    22157           
  Misses       1255     1255

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cpu
cpu approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :-)

@djc djc added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 659e876 Sep 24, 2024
@djc djc deleted the jbp-no-docopt branch September 24, 2024 17:59
@ctz ctz mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ctz @djc @cpu