Send flights of handshake messages in single message #2120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesClick to expand
Other differencesClick to expand
Additional informationCheckout details:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2120 +/- ##
==========================================
- Coverage 94.66% 94.64% -0.03%
==========================================
Files 102 102
Lines 23450 23415 -35
==========================================
- Hits 22198 22160 -38
- Misses 1252 1255 +3 ☔ View full report in Codecov by Sentry. |
4fd718d to
43330bd
Compare
cpu
approved these changes
Sep 13, 2024
Member
cpu
left a comment
There was a problem hiding this comment.
This is really nice, outside of any perf benefits I think it has an improvement on the overall readability/structure of the code.
Comment on lines
-33
to
-35
| "Ok(BlockedHandshake)", | ||
| "Ok(BlockedHandshake)", | ||
| "Ok(BlockedHandshake)", |
Member
There was a problem hiding this comment.
it's interesting to observe the optimization so directly in this API's expected states 👍
| } | ||
| } | ||
|
|
||
| pub(crate) type HandshakeFlightTls12<'a> = HandshakeFlight<'a, false>; |
Member
There was a problem hiding this comment.
Is the TLS 1.2 use-case landed alongside the new types to avoid dead code warnings? I think this diff would be easier to digest if it were separated out like the TLS 1.3 case but I wager that might produce warnings and I don't feel very strongly.
Member
There was a problem hiding this comment.
In general, not sure I'm convinced of the benefit of this type alias.
Member
There was a problem hiding this comment.
I think the type alias is mildly useful in so much as false in the generic bound doesn't clearly map to TLS1.2 without doing a bit of digging around.
Member
Author
There was a problem hiding this comment.
Yes I would like to avoid the true/false thing leaking out of this file, as far as possible.
My second choice would be to stop this type being generic like this, and just have two different constructors (eg, new_tls12(), new_tls13() or similar) and rely on everything being inlined into their uses.
| } | ||
| } | ||
|
|
||
| pub(crate) struct HandshakeFlight<'a, const TLS13: bool> { |
Member
There was a problem hiding this comment.
I briefly considered the restrictiveness of the const generic bool here vs something more expressive but decided it was premature optimization and this seems quite reasonable after all.
| transfer(&mut client, &mut server); | ||
| server.process_new_packets().unwrap(); | ||
| { | ||
| let mut pipe = OtherSession::new(&mut client); |
Member
There was a problem hiding this comment.
Nice to see the improvements reflected here too 🚀
djc
approved these changes
Sep 15, 2024
| } | ||
| } | ||
|
|
||
| pub(crate) type HandshakeFlightTls12<'a> = HandshakeFlight<'a, false>; |
Member
There was a problem hiding this comment.
In general, not sure I'm convinced of the benefit of this type alias.
Member
Agreed, -11 lines for an efficiency improvement seems like a really good deal. |
This will only have any positive effect with client auth.
43330bd to
46204e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is generally only valuable for TLS1.3, where we're saving encryption overheads several times over. For TLS1.2 there are no encrypted handshake messages, so we're only saving 20 bytes on the wire in the server -> client direction.
fixes #2041