Take aws-lc-rs 1.9#2118
Merged
Merged
Conversation
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesClick to expand
Other differencesClick to expand
Additional informationCheckout details:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2118 +/- ##
=======================================
Coverage 94.65% 94.65%
=======================================
Files 102 102
Lines 23424 23432 +8
=======================================
+ Hits 22172 22180 +8
Misses 1252 1252 ☔ View full report in Codecov by Sentry. |
cpu
approved these changes
Sep 9, 2024
cpu
left a comment
Member
There was a problem hiding this comment.
Prepare 0.23.13
Can you add some proposed release notes to the PR desc for this? Thank you! 🙇
5687613 to
ba48261
Compare
Member
Author
Added |
Member
|
Some ideas for the release notes to consider:
Maybe this could have a brief mention of the motivation? Suggested wording: "This may be useful in situations where your application wishes to ensure consistent use of a custom crypto provider throughout the dependency tree." ? I thought about the same feedback for the ticketer change but decided the motivation is too in the weeds to be worth calling out top-line in changelog. It's in the PR if anyone is especially curious about the change.
Can we add a bit more detail here? In particular I think it would be worth mentioning |
Contributor
I thought this has already been present (and don't see this in the files changed), or am I mistaken somehow? |
Member
You're correct, the code for this already landed, but it hasn't been included in a published release yet. This section of the PR description isn't just for new code in this branch, it's also proposing changelog content for the release that covers this branch's work and also the work that's queued but unreleased in Does that help clarify? |
Contributor
Got it thanks @cpu ... I think it would be ideal if this could have been more clear in the description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should improve matters for people building aws-lc-rs on windows thanks to the prebuilt-nasm feature: fixes #1913.
It also removes
synfrom the dependencies of rustls; a diff ofcargo tree --edges normal --all-featuresincludes:Draft release notes
custom-providercrate feature to disable installation of built-in provider. This may be useful in situations where your application wishes to ensure consistent use of a custom crypto provider throughout the dependency tree. Thanks to @stormshield-gtmax_early_data_sizebytes of early data will be accepted, if it is read while it is being received. Thanks to @tahmid-23 for the report and fix.