remove Send + Sync not needed from client session storage field#2087
Merged
ctz merged 1 commit intoAug 23, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2087 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 102 102
Lines 23497 23497
=======================================
Hits 22271 22271
Misses 1226 1226 ☔ View full report in Codecov by Sentry. |
djc
approved these changes
Aug 23, 2024
djc
left a comment
Member
There was a problem hiding this comment.
Since we don't have these bounds on any of the other Arc<dyn>s in the ServerConfig (or ClientConfig), I suppose this is fine.
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesClick to expand
Other differencesClick to expand
Additional informationCheckout details:
|
ctz
approved these changes
Aug 23, 2024
ctz
left a comment
Member
There was a problem hiding this comment.
Thanks!
(I missed it initially, but this is good because StoresServerSessions already has Send + Sync as trait bounds. That should be a clippy lint!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on a proposal to support using
alloc::rc::Rc, as discussed as a possible solution for #2068, I discovered a case of extraSend + Syncthat I think is not needed & one more thing that would need to be updated. Of course I could remove this as part of my proposal for #2068, but would rather keep this kind of cleanup in a separate proposal & commit if possible.FYI I did already get a green build of this proposal in my own fork.