Take latest bogo test suite#1314
Merged
Merged
Conversation
Addresses ALPNServer-Reject-* tests.
This is a BoringSSL-specific feature that micro-optimises private key usage when the key is behind an RPC.
Codecov Report
@@ Coverage Diff @@
## main #1314 +/- ##
==========================================
- Coverage 95.81% 95.81% -0.01%
==========================================
Files 60 60
Lines 14455 14467 +12
==========================================
+ Hits 13850 13861 +11
- Misses 605 606 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
djc
approved these changes
Jun 12, 2023
cpu
approved these changes
Jun 12, 2023
In TLS1.3 middlebox-compatiblity mode requires a random session_id. If TLS1.3 is disabled, the TLS1.2 rules apply: > This field is empty if no session_id is available, or if the > client wishes to generate new security parameters. Tested by bogo TLS12NoSessionID-TLS13
On the assumption that the server might unilaterally expire the oldest tickets, it makes the most sense to use the ones we received most recently. This has a possible marginal improvement in accepted resumption.
Previously this was out of spec, but safe, because (in psk_mode_offered) we just looked for PSK_DHE_KE and treated a missing extension as being empty. Tested by bogo TLS13-SendNoKEMModesWithPSK-Server.
This checks that early data continues to work after the server's first flight is being received. This defends a BoringSSL bug fix that is private, so it's a bit of a guess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1158