examples: add writing and reading ca files#378
Closed
iamjpotts wants to merge 1 commit into
Closed
Conversation
9aa7cf7 to
891f697
Compare
Member
|
Thanks for your efforts. I'm generally pretty wary of adding too many examples since they can add maintenance costs. In this case, your example is pretty long already (200+ lines) and IMO working directly on the file system makes it less generalizable (and more likely to leave clutter around if you actually try to run it). While I agree it could be useful to have a specific example that shows how to load an existing CA certificate without resigning, I'd prefer a more concise and focused piece of code for that. |
Contributor
Author
Signed-off-by: Joshua Potts <8704475+iamjpotts@users.noreply.github.com>
891f697 to
421f5e6
Compare
Contributor
Author
|
Force push only renames |
Contributor
Author
|
Replaced by #379. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an example based on
0.14that generates a certificate chain, and stores each step as PEM files, and reads from the PEM files for the next step, rather than doing all of the steps in memory.Related:
Certificate::from_der+Certificate::from_pem#274CertifiedIssuer::from_ca_cert_{pem,der}? #375@oscartbeaumont said he "wanted to know if there is a way to load an existing CA certificate to sign some more certificates without triggering signing."
@acul009 mentioned the api obscurity as discouraging an upgrade from
0.12to0.13in #274 (comment).This new example does not resign any certificates, instead loading the already signed certificate as an
Issuer.