Conversation
7709d7c to
073c32d
Compare
cpu
reviewed
Sep 3, 2025
cpu
left a comment
Member
There was a problem hiding this comment.
just a quick initial pass. I think the CI failures need addressing as well.
Member
Author
This seems to be another annoying feature unification error... Not sure how to fix this yet. |
est31
reviewed
Sep 4, 2025
f741598 to
9f325ab
Compare
est31
approved these changes
Sep 9, 2025
est31
left a comment
Member
There was a problem hiding this comment.
a bit wary of unstable features as they bring issues to crates.io, but I guess we can experiment with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would like to use this for testing in rustls.