tests: only test against openssl on Unix#350
Merged
Merged
Conversation
ea968cf to
01a2af8
Compare
cpu
approved these changes
May 20, 2025
est31
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a while now, build-windows has been failing with some non-obvious issues.
First failing run:
Last working run:
Ostensibly, nothing changed between these two runs (including the GitHub runner image and operating system and the
Cargo.lockfile), so I'm not sure what's going on here. Given the way we use OpenSSL (only to test that our generated artifacts are compatible with OpenSSL), I think it's fine to limit such testing tounixplatforms only, avoiding a bunch of complexity from building OpenSSL on Windows.