I don't like the strong use of Self here: let's not change that: if you don't use an IDE, you can quickly find where some type is constructed or used, but if it's mentioned via Self, that's not possible. The other changes are fine.

I disagree: Self is only used in the context of an impl, so it's relatively straightforward (and often pretty close to what you're looking at) to just look at one level up in the hierarchy.

Dropped the commit for now.

if you don't use an IDE

This doesn't seem like a category of contributor/user worth optimizing for IMO.

This doesn't seem like a category of contributor/user worth optimizing for IMO.

even if you do use an IDE, not every time you interact you have an IDE around, say when reviewing PRs on github for example, or when searching on github search. And IDE features are not omnipresent/omniscient. e.g. macros come in mind, or stuff like #[cfg(test)] code.