Conversation
est31
left a comment
There was a problem hiding this comment.
makes sense but can you squash?
Why? All of these commits compile and could likely pass CI on their own. |
|
I feel it's too fine. I think it should be easy to squash the "Move ..." commits together, they are form an independent unit compared to the other commits. |
What are the downsides of merging smaller commits? If there's ever a regression or you want to sift through |
|
On the other hand, it's harder to understand the motivation of a bigger commit compared to a small one. But whatever, it's bikeshedding. Let's just merge this one. |
This takes the processing steps for transforming an
x509_parser::CertificateintoCertificateParamsand distributes them over the relevant element's types, in preparation for splittingfrom_ca_cert_pem()andfrom_ca_cert_der()fromCertificateParams(to make it statically obvious that their use is only intended to build anIssuer).