Move string types to separate module#329
Merged
Merged
Conversation
b7e3213 to
9e54673
Compare
cpu
reviewed
Apr 16, 2025
cpu
left a comment
Member
There was a problem hiding this comment.
Nice! I like it.
I think there are a couple CI failures to sort out, one of which is a semver compat check issue I left a comment about.
85e90a9 to
64279e3
Compare
Member
I fixed a build failure in the version bump commit ( It seemed easier to fix it & push than to do another back-and-forth round. Hope you don't mind. |
cpu
approved these changes
Apr 18, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at the rustdoc, it's a bit weird to see the string types mixed up with certificate related stuff.
The rename was done because it follows the way
stdnames its modules.