Upgrade webpki dev-dependency to 0.102#215
Merged
Merged
Conversation
cpu
approved these changes
Jan 18, 2024
Comment on lines
-601
to
-603
| webpki_crl | ||
| .verify_signature(&[&webpki::ECDSA_P256_SHA256], raw_spki.value()) | ||
| .expect("failed to validate CRL signature"); |
Member
There was a problem hiding this comment.
just noting for other reviewers that this hunk of test code falls away because we removed the verify_signature fn of the CRL type upstream. It didn't mesh well with the existing API surface, was difficult to use (as evidenced by the SPKI SEQUENCE dance), and had no other consumers we were aware of except this unit test.
The test_webpki_crl_revoke test that remains uses the CRL for a revocation checking decision and the webpki crate will verify the signature as part of that work.
est31
approved these changes
Jan 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.