feat: add const try_from_str constructor to DnsName type.#68
Closed
DSharifi wants to merge 1 commit intorustls:mainfrom
Closed
feat: add const try_from_str constructor to DnsName type.#68DSharifi wants to merge 1 commit intorustls:mainfrom
try_from_str constructor to DnsName type.#68DSharifi wants to merge 1 commit intorustls:mainfrom
Conversation
cpu
approved these changes
Jan 24, 2025
Member
cpu
left a comment
There was a problem hiding this comment.
Thanks 👍 Seems reasonable to me!
Would you mind writing a commit message? It could be as simple as the PR description.
Contributor
Author
|
Thanks for the quick review! I amended the commit message now to the PR title. |
djc
reviewed
Jan 24, 2025
Member
|
Please squash all your changes into a single commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a const
DnsName::from_strmethod to createDnsNamein a const setting.validate()is refactored to use while loop instead of for loop as for loops are non const.