Skip to content

fix misc. clippy findings#65

Merged
cpu merged 3 commits intorustls:mainfrom
cpu:cpu-clippy-fix
Nov 28, 2024
Merged

fix misc. clippy findings#65
cpu merged 3 commits intorustls:mainfrom
cpu:cpu-clippy-fix

Conversation

@cpu
Copy link
Member

@cpu cpu commented Nov 28, 2024

See each commit for more information.

cpu added 3 commits November 28, 2024 15:16
Applies the result of `cargo clippy --fix`.
Of the form:

```
warning: empty line after doc comment
   --> src/lib.rs:120:1
    |
120 | / /// ```
121 | |
    | |_^
...
124 |   pub enum PrivateKeyDer<'a> {
    |   -------------------------- the comment documents this enum
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
    = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
    = help: if the empty line is unintentional remove it
```
Of the form:

```
error: redundant pattern matching, consider using `is_none()`
   --> tests/pem.rs:312:13
    |
312 |     assert!(matches!(iter.next(), None));
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `iter.next().is_none()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
    = note: `-D clippy::redundant-pattern-matching` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::redundant_pattern_matching)]`

error: could not compile `rustls-pki-types` (test "pem") due to 1 previous error
```
@cpu cpu self-assigned this Nov 28, 2024
Copy link
Member

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing all these!

@cpu cpu added this pull request to the merge queue Nov 28, 2024
Merged via the queue into rustls:main with commit 40ae281 Nov 28, 2024
@cpu cpu deleted the cpu-clippy-fix branch November 28, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants