-
Notifications
You must be signed in to change notification settings - Fork 854
helm: refactor helm chart #1122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jurim76 Thanks for you contribution.
Thx. |
de921f7 to
0ca2395
Compare
|
@majinghe |
| enabled: true | ||
| distributed: | ||
| enabled: false | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our default mode should be distributed with 4 pods and 16 pvc, so distributed.enabled should be true.
|
@jurim76 Just leave one comment, please FYI. In addition, there are some conflicts, after resolved, will merge this PR. Thx. |
d03f15f to
0bdf72e
Compare
Signed-off-by: Juri Malinovski <juri.malinovski@coolbet.com> return mode Signed-off-by: Juri Malinovski <juri.malinovski@coolbet.com>
|
@majinghe |
|
@jurim76 Have you tested on local env due to the code had a lot of changes, i will need to test on local env for standalone and distributed mode. Will update test result here. |
|
@majinghe yep, works for me btw, in distributed mode the pod was crushed/recreated 3 times before pod got running. # Standalone mode enabled
$ helm install rustfs . -f values.custom.yaml --set mode.standalone.enabled=true --set mode.distributed.enabled=false
NAME: rustfs
LAST DEPLOYED: Sun Dec 14 15:26:14 2025
NAMESPACE: test
STATUS: deployed
REVISION: 1
NOTES:
1. Watch all pods come up
kubectl get pods -w -l app.kubernetes.io/name=rustfs -n test
2. Visit the dashboard
https://rustfs.opsdev.clusters.***
$ kubectl get pods -w -l app.kubernetes.io/name=rustfs -n test
NAME READY STATUS RESTARTS AGE
rustfs-675ff84d4-mpq9k 1/1 Running 0 93s
# Distributed mode enabled
$ helm install rustfs . -f values.custom.yaml --set mode.standalone.enabled=false --set mode.distributed.enabled=true
NAME: rustfs
LAST DEPLOYED: Sun Dec 14 15:30:14 2025
NAMESPACE: test
STATUS: deployed
REVISION: 1
NOTES:
1. Watch all pods come up
kubectl get pods -w -l app.kubernetes.io/name=rustfs -n test
2. Visit the dashboard
https://rustfs.opsdev.clusters.***
$ kubectl get pods -w -l app.kubernetes.io/name=rustfs -n test
NAME READY STATUS RESTARTS AGE
rustfs-0 1/1 Running 3 (113s ago) 2m22s
rustfs-1 1/1 Running 3 (111s ago) 2m21s
rustfs-2 1/1 Running 3 (112s ago) 2m21s
rustfs-3 1/1 Running 3 (108s ago) 2m21s
# values.custom.yaml
imagePullSecrets:
- name: regcred
podLabels:
owner_team: ops-infra
commonLabels:
owner_team: ops-infra
ingress:
className: "nginx"
hosts:
- host: rustfs.opsdev.clusters.***
paths:
- path: /
pathType: ImplementationSpecific
tls:
enabled: false
affinity:
podAntiAffinity:
enabled: true
topologyKey: kubernetes.io/hostname
nodeAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
nodeSelectorTerms:
- matchExpressions:
- key: role
operator: In
values:
- storage-node
storageclass:
name: topolvm-xfs
size: 1Gi
dataStorageSize: 1Gi
logStorageSize: 1Gi |
|
@jurim76 I finished testing on local kind env, worked fine. Thanks for your contribution. /LGTM /cc @houseme @loverustfs |
Ok. |
|
Hey @majinghe , Merged. |
|
Hi @jurim76, Thank you for your contribution! |
Type of Change
Related Issues
Summary of Changes
RUSTFS_VOLUMESwith a template helper, allow to override RUSTFS_VOLUMES in values filecommonLabelssupportconfig.rustfs.obs_environmentconfig parameterrustfs.selectorLabelstemplate, replaceapplabel withapp.kubernetes.io/namelabelpodSecurityContextindentpodAntiAffinityandnodeAffinitysupportnodeSelectorsupportChecklist
Impact
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.