This repository was archived by the owner on Jun 24, 2024. It is now read-only.
Sync to llama.cpp + GGML version as of 20230407 09:57 AM UTC.#119
Merged
philpax merged 2 commits intorustformers:mainfrom Apr 7, 2023
Merged
Sync to llama.cpp + GGML version as of 20230407 09:57 AM UTC.#119philpax merged 2 commits intorustformers:mainfrom
philpax merged 2 commits intorustformers:mainfrom
Conversation
philpax
reviewed
Apr 7, 2023
Collaborator
|
Seems pretty reasonable from what I can see, will need to test but have no objections to merging otherwise |
Collaborator
|
Can you also update https://github.com/rustformers/llama-rs/blob/main/ggml-sys/ggml/CREDITS.txt ? |
Contributor
Author
|
Can do! By the way, the contributing thing refers to |
Collaborator
made it clearer, ty |
philpax
approved these changes
Apr 7, 2023
Collaborator
philpax
left a comment
There was a problem hiding this comment.
Tested on macOS M1 and Windows x86-64 with no issues. Let's do it 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would have been a pretty interesting first issue.
This also includes nuking the
increased_determinismoption since it's no longer needed.I confirmed that it's possible to change the thread/batch sizes with deterministic results. I haven't don't any extensive performance testing but there didn't seem to be an obvious issue.
Other people should probably do some testing before this gets merged as it's a fairly complicated change. I can't say I really understood what I was porting across.
Closes #118
Closes #67