Move Windows backend to winit-win32#4247
Merged
Conversation
5 tasks
kchibisov
approved these changes
May 21, 2025
Member
kchibisov
left a comment
There was a problem hiding this comment.
This looks fine, remember to reserve the names on crates.io for 0.0.0 which is just empty crate with winit's license.
Member
Author
Didn't want to until we settled on the name. But yeah, I will. |
7a4e863 to
91b7237
Compare
Member
it's not like we can not rename later on tbf. |
notgull
approved these changes
May 24, 2025
kchibisov
approved these changes
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3433.
I'm choosing the name
winit-win32because that is the name of the actual API we're using, and because in the future it might make sense to have different Windows backends (such aswinit-winrt). See #4246 for background.I decided to not yet rename all the other user-facing things like extension traits etc., that can be done in a follow-up.