Move shared code to new crate winit-common#4241
Conversation
5579a2f to
6a42da6
Compare
cefed24 to
96b66dc
Compare
c614ee3 to
a83ee97
Compare
a83ee97 to
24a7d42
Compare
24a7d42 to
b9bfa01
Compare
|
One thing I'm not entirely sure is that whether we want |
I'm not sure either. Building on the discussion in #4246, we might not even want to call it "linux" and "apple" - maybe rather |
|
Yeah, that's true, so I'd probably be infavour of the common module to just add stuff that could be needed by multiple backends to e.g. write handling that does the same thing on every platform. So probably a big common crate for stuff we need is a better options. |
b9bfa01 to
74d68ce
Compare
ee80ce8 to
035b43d
Compare
|
I moved it to Check it out, and let me know what you think? |
winit-apple-commonwinit-common
kchibisov
left a comment
There was a problem hiding this comment.
I'd probably still move apple specific stuff into separate folder, like event_handler for now. We can also use the build.rs stuff we have to gate features that can not really build on platforms.
I put the
But the CoreFoundation stuff can build on more platforms - e.g. if you have certain GNUStep libraries installed, you can build Similarly, e.g. |
|
maybe group in objc it then, so it's a bit clear what it is about? |
|
I guess I'm also fine with:
( |
Can the AppKit backend be used on Linux? If not, then what's the point of the core_foundation code on Linux? A hypothetical separate GNUStep backend? (we don't want to compile any more code than is strictly necessary) |
Probably not functionally yet, but I think it'd be interesting to move towards that, yes. (GNUStep contains CoreFoundation/Foundation/AppKit reimplementations).
I've |
6e0a6ce to
a22e93c
Compare
a22e93c to
35b70c4
Compare
This crate contains helper code that is useful for both the AppKit and the UIKit backends, as well as the shared XKB helper code.
Part of #3433.