Skip to content

chore: Import from winit-core instead of the top-level crate#4225

Merged
kchibisov merged 3 commits intomasterfrom
madsmtm/import-winit-core
May 17, 2025
Merged

chore: Import from winit-core instead of the top-level crate#4225
kchibisov merged 3 commits intomasterfrom
madsmtm/import-winit-core

Conversation

@madsmtm
Copy link
Copy Markdown
Member

@madsmtm madsmtm commented May 15, 2025

Change imports of crate:: to winit_core:: when possible in platform impl. This is part of the preparation for splitting backends out into separate crates, tracked in #3433.

This is basically only automated renaming, you can reproduce the first commit with:

find ./src/platform_impl -type f -exec sed -i '' 's/crate::/winit_core::/g' {} \;
find ./src/platform_impl -type f -exec sed -i '' 's/winit_core::platform/crate::platform/g' {} \;
find ./src/platform_impl -type f -exec sed -i '' 's/winit_core::dpi::/dpi::/g' {} \;
cargo +nightly fmt

With the second commit reverting one of these that were incorrectly changed.

madsmtm added 2 commits May 15, 2025 22:45
Reproduce with:
find ./src/platform_impl -type f -exec sed -i '' 's/crate::/winit_core::/g' {} \;
find ./src/platform_impl -type f -exec sed -i '' 's/winit_core::platform/crate::platform/g' {} \;
find ./src/platform_impl -type f -exec sed -i '' 's/winit_core::dpi::/dpi::/g' {} \;
cargo +nightly fmt
Copy link
Copy Markdown
Member

@kchibisov kchibisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine after CI fixed.

@kchibisov kchibisov merged commit c846f67 into master May 17, 2025
57 checks passed
@kchibisov kchibisov deleted the madsmtm/import-winit-core branch May 17, 2025 02:26
@madsmtm madsmtm mentioned this pull request May 15, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S - maintenance Repaying technical debt

Development

Successfully merging this pull request may close these issues.

2 participants