Conversation
8c35137 to
d612131
Compare
kchibisov
commented
Mar 23, 2025
madsmtm
reviewed
Mar 27, 2025
Member
madsmtm
left a comment
There was a problem hiding this comment.
Looks good overall, fine with cleaning this up properly later
8a34247 to
d5678e0
Compare
3fbacec to
4f32416
Compare
Same as for `CustomCursor`. However, the API uses `dyn` stuff only because of `Windows` backend at the time of writing, generally, platforms should just have a separate method that deals with all of that, and e.g. top-level winit only guarantees `Rgba`.
4f32416 to
67dbd9d
Compare
Member
Author
|
@madsmtm any chance to give one more look? |
Member
|
Sorry, missed the ping. But it looks fine to me. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as for
CustomCursor. However, the API usesdynstuff only because ofWindowsbackend at the time of writing, generally, platforms should just have a separate method that deals with all of that, and e.g. top-level winit only guaranteesRgba.Part of #3433.
changelogmodule if knowledge of this change could be valuable to users