cursor: refactor CustomCursor to be dyn#4163
Conversation
064d689 to
7ef88ff
Compare
madsmtm
left a comment
There was a problem hiding this comment.
I suspect we'll want to remove CustomCursorSource altogether, and provide ActiveEventLoop::create_custom_cursor_from_[rgba|animation|url](...) instead.
But that can (and should) be done in a follow-up, happy with this for now!
No, it doesn't require anything running and should be loadable without event loop. The |
I meant for these proposed methods to directly return |
|
Our custom cursors work in a way that we create a source and then load into the event loop so cursor is not slow. The methods like So I don't see how we'd move away from it or what for. We may eventually figure out how to merge source and cursor so the loading is transparent, but that's a different matter, if that's what you've asked about, indeed. |
Yeah, that's what I was discussing, and it's indeed a different matter. |
Same as for `MonitorHandle`, the source was changed to support all kinds of sources.
7ef88ff to
17ea40f
Compare
Same as for
MonitorHandle, the source was changed to support all kinds of sources.Part of #3433.