Merge all WindowId into a single type in the core crate#3902
Merged
Merge all WindowId into a single type in the core crate#3902
WindowId into a single type in the core crate#3902Conversation
eea3202 to
4be1aac
Compare
Member
|
Linked PR got merged, so this should be unblocked now. |
4be1aac to
7e054cb
Compare
7e054cb to
3a8e5fc
Compare
kchibisov
requested changes
Sep 29, 2024
Member
kchibisov
left a comment
There was a problem hiding this comment.
I've rebased, other than that I don't have any issues.
3a8e5fc to
a53ba65
Compare
80f5712 to
0697847
Compare
kchibisov
approved these changes
Oct 8, 2024
0697847 to
0eb96de
Compare
WindowId is a window _identifier_, and as such doesn't store anything (unlike a _handle_). So we can safely make only be defined once, in the core crate. There are a few backends where we still use `into_raw` internally; I consider these patterns discouraged, we should not be passing around important state in the window id.
0eb96de to
954befe
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WindowId is a window identifier, and as such doesn't store anything (unlike a handle). So we can safely make only be defined once, in the core crate.
There are a few backends where we still use
into_rawinternally; I consider these patterns discouraged, we should not be passing around important state in the window id.Builds upon #3864. Part of #3433.