android: add ActiveEventLoopExtAndroid::android_app#3828
Merged
Conversation
MarijnS95
approved these changes
Jul 26, 2024
Member
MarijnS95
left a comment
There was a problem hiding this comment.
Also didn't test but looks trivial enough.
Contributor
|
Yes, that's the API I need. Thanks. |
696cdef to
1ace22e
Compare
1ace22e to
e939a4f
Compare
MarijnS95
approved these changes
Jul 26, 2024
This type comes from the user and stored for the entire lifetime, so no need to hide it from them after they've passed it to winit. Fixes #3818.
e939a4f to
05483a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This type comes from the user and stored for the entire lifetime, so no need to hide it from them after they've passed it to winit.
Fixes #3818.
--
I can not really test it, but it's rather trivial and should just work, I guess.
@mwcampbell I guess you need something like that?