Web: Remove some unnecessary compatibility code#3766
Merged
daxpedda merged 1 commit intorust-windowing:masterfrom Jun 28, 2024
Merged
Web: Remove some unnecessary compatibility code#3766daxpedda merged 1 commit intorust-windowing:masterfrom
daxpedda merged 1 commit intorust-windowing:masterfrom
Conversation
madsmtm
approved these changes
Jun 28, 2024
Member
madsmtm
left a comment
There was a problem hiding this comment.
Was there a reason why we didn't use screen[X|Y] before?
91aac75 to
bbf16bc
Compare
Member
Author
We moved from mouse to pointer events ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently
MouseEvent.movementX/Yshould not be used anymore.Replacing it with
screenX/Ysimplifies the code, removes unnecessary conversion and increases accuracy.Addresses #2875.