Move iOS and macOS implementations into new apple module#3756
Merged
Move iOS and macOS implementations into new apple module#3756
apple module#3756Conversation
57fc536 to
f6e024a
Compare
notgull
approved these changes
Jun 24, 2024
Contributor
notgull
left a comment
There was a problem hiding this comment.
Nice! I hope this paves the way for further deduplication.
f6e024a to
f7272df
Compare
daxpedda
approved these changes
Jun 24, 2024
f7272df to
e7ee057
Compare
|
I'm a bit of a noob, is the |
Member
Author
|
Yup, but UIKit is also for tvOS, watchOS, visionOS and Mac Catalyst. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move iOS and macOS implementations to a shared folder called
apple, to allow us to reduce the code-duplication between these platforms in the future.The folder structure is now:
src/platform_impl/apple/appkit/uikit/example_shared_file.rsmod.rsPart of #1029.
I considered calling the folder
darwin, as that's the name of the underlying core OS that all of these platforms share, but the implementation here in Winit is really Apple-specific, i.e. even if Apple created a new OS different from Darwin, they would likely still port Foundation and UIKit to that, and the module name would still fit.