Closed
Conversation
kchibisov
requested changes
May 28, 2024
Member
kchibisov
left a comment
There was a problem hiding this comment.
It should be on its own trait as it was requested multiple times. The Event will be gone soon, so no need to add anything into it.
4 tasks
Member
|
Thanks for the PR, though I'm going to resolve this in a different way, see #1751 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit an event when the application is opened by clicking on files in Finder or by dropping files on the Dock icon. This is macOS specific, as other OSs usually communicate that information through
std::env::args().I am not sure with the current implementation, i.e. maybe the
OpenFilesevent should be defined in a macOS specific event enum type?This basically implements #1751.
To test the event, a application bundle is required:
The
Info.plistshould look like this:Also, you need to implement
fn ApplicationHandler::open_files(&mut self, files: Vec<PathBuf>).changelogmodule if knowledge of this change could be valuable to users