event_loop: remove deprecated run APIs#3683
Merged
Conversation
3fe757d to
fc20c52
Compare
madsmtm
approved these changes
May 5, 2024
Member
madsmtm
left a comment
There was a problem hiding this comment.
👍. Will follow-up with a PR to change the macOS and iOS backends to not need the shim any more.
94ddce1 to
37c754b
Compare
daxpedda
approved these changes
May 19, 2024
The APIs are not well suited for the `&dyn ApplicationHandler` model and `Box<dyn EventLoop>` structure, thus remove them.
37c754b to
85a4c9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The APIs are not well suited for the
&dyn ApplicationHandlermodel andBox<dyn EventLoop>structure, thus remove them.changelogmodule if knowledge of this change could be valuable to users